feat(xo-web): merge backups synchronously

[stephane-m-dev]

Description

[Backup] Add Merge backups synchronously to Advanced Settings
We need to introduce a new backup advanced setting: synchronousMerge

XO-356
https://project.vates.tech/vates-global/projects/70ab2907-1ac3-4e7d-831f-a8752c36474d/issues/63832d60-23c4-44dc-a9e1-462cd94565b7

Checklist

• Commit
  • Title follows commit conventions
  • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
  • If bug fix, add Introduced by
• Changelog
  • If visible by XOA users, add changelog entry
  • Update "Packages to release" in CHANGELOG.unreleased.md
• PR
  • If UI changes, add screenshots
  • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

• develop skills of junior reviewers
• limit the workload for senior reviewers
• limit the number of unnecessary changes by the author

1. The author creates a PR.
2. Review process:
   1. The author assigns the junior reviewer.
   2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
   3. The junior reviewer assigns the senior reviewer.
   4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

1. The author can request a review at any time, even if the PR is still a Draft.
2. In theory, there should not be more than one reviewer at a time.
3. The author should not make any changes:
   • When a reviewer is assigned.
   • Between the junior and senior reviews.

[b-Nollet]

I may be missing something, but I don't get why we use backup report templates here (mjml and compactMjml), I feel like using a boolean value and renaming mergeBackupSynchronouslyTpl into mergeBackupSynchronously would make more sense.

[stephane-m-dev]

I may be missing something, but I don't get why we use backup report templates here (mjml and compactMjml), I feel like using a boolean value and renaming mergeBackupSynchronouslyTpl into mergeBackupSynchronously would make more sense.

@b-Nollet You are absolutely right. But I haven't found how to make the toggle work without that, and pass a boolean from the front side.
How can we do that?

[b-Nollet]

@b-Nollet You are absolutely right. But I haven't found how to make the toggle work without that, and pass a boolean from the front side. How can we do that?

You can use toggles from other pages as example.
I think you can just use value={mergeBackupSynchronously} for the toggle instead of the current value and setGlobalSettings({mergeBackupSynchronously}) in the setMergeBackupsSynchronously function.

I haven't tested this though, and I'm not a front expert, so feel free to ask Pierre or Mathieu if in doubt.

[fbeauchamp]

You can look at the toggle used to enable/disable NBD , specifically state.inputPreferNbd and effects.setPreferNbd to see how to handle boolean in the front

this is seen in the api and backend as the preferNbd setting

[fbeauchamp]

Suggested change

	mergeBackupsSynchronously: 'Merge backups synchronously',
	mergeBackupsSynchronously: 'Merge backups synchronously. This will use more resources on the backup thread, but ensure there is no locking error when chaining multiple backup jobs on the same remote',

[stephane-m-dev]

Done