-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VMs with this tag xo:no-health-check
or xo:no-health-check=REASON
will not be tested by health check
#8189
Open
fbeauchamp
wants to merge
5
commits into
master
Choose a base branch
from
feat_ignore_healthcheck
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeauchamp
force-pushed
the
feat_ignore_healthcheck
branch
from
December 11, 2024 14:18
17d44db
to
b02e744
Compare
@@ -1984,6 +1984,7 @@ const messages = { | |||
remoteLoadBackupsFailureMessage: 'Failed to load backups from {name}.', | |||
vmsTags: 'VMs tags', | |||
tagNoBak: 'VMs with this tag will not be backed up {reason, select, null {} other {({reason})}}', | |||
tagNoHealthCheck: 'VMs with this tag will not tested by health check {reason, select, null {} other {({reason})}}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo : will not be tested
stephane-m-dev
approved these changes
Dec 11, 2024
MathieuRA
requested changes
Dec 11, 2024
@@ -35,6 +37,7 @@ | |||
|
|||
<!--packages-start--> | |||
|
|||
- @xen-orchestra/backups minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add xo-web
fbeauchamp
force-pushed
the
feat_ignore_healthcheck
branch
from
December 13, 2024 14:32
b02e744
to
4626a11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Short explanation of this PR (feel free to re-use commit message)
Checklist
Fixes #007
,See xoa-support#42
,See https://...
)Introduced by
CHANGELOG.unreleased.md
Review process
Notes: