feat(xo-server/xo-web): in host advanced tab, display mdadm status #8190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathieuRA
requested changes
Dec 16, 2024
| @@ -1569,4 +1569,24 @@ export default class Xapi extends XapiBase { | |||
|
|
|||
| return { currentBiosVersion, latestBiosVersion, biosLink, isUpToDate } | |||
| } | |||
|
|
|||
| async getHostMdadmHealth(hostId, { cache } = {}) { | |||
There was a problem hiding this comment.
Why put a cache in this method?
check_raid_pool takes a long time to respond?
| return cache.get(hostId) | ||
| } | ||
| try { | ||
| const result = await this.call('host.call_plugin', this.getObject(hostId).$ref, 'raid.py', 'check_raid_pool', {}) |
There was a problem hiding this comment.
If the call take more than a second, use this.callAsync
Comment on lines
+1573
to
+1591
| async getHostMdadmHealth(hostId, { cache } = {}) { | ||
| if (cache?.has(hostId)) { | ||
| return cache.get(hostId) | ||
| } | ||
| try { | ||
| const result = await this.call('host.call_plugin', this.getObject(hostId).$ref, 'raid.py', 'check_raid_pool', {}) | ||
| const parsedResult = JSON.parse(result) | ||
|
|
||
| cache?.set(hostId, parsedResult) | ||
|
|
||
| return parsedResult | ||
| } catch (error) { | ||
| if (error.code === 'XENAPI_MISSING_PLUGIN' || error.code === 'UNKNOWN_XENAPI_PLUGIN_FUNCTION') { | ||
| return null | ||
| } else { | ||
| throw error | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
IMHO, this method can be moved into @xen-orchestra/xapi/host.mjs
| @@ -63,6 +64,7 @@ export default class HostItem extends Component { | |||
| state = { | |||
| isHostTimeConsistentWithXoaTime: true, | |||
| isPubKeyTooShort: false, | |||
| mdadmHealth: null, | |||
There was a problem hiding this comment.
Why initialize as null instead of undefined?
| @@ -262,6 +273,17 @@ export default class HostItem extends Component { | |||
| }) | |||
| } | |||
|
|
|||
| if (mdadmHealth?.raid?.State && !['clean', 'active'].includes(mdadmHealth.raid.State)) { | |||
There was a problem hiding this comment.
Always explicit condition. Exepct for boolean
Suggested change
| if (mdadmHealth?.raid?.State && !['clean', 'active'].includes(mdadmHealth.raid.State)) { | |
| if (mdadmHealth?.raid?.State !== undefined && !['clean', 'active'].includes(mdadmHealth.raid.State)) { |
| this.setState({ | ||
| isHtEnabled: await isHyperThreadingEnabledHost(host).catch(() => null), | ||
| isSmartctlHealthEnabled, | ||
| pciStateById, | ||
| smartctlUnhealthyDevices, | ||
| unhealthyDevicesAlerts, | ||
| isPciPassthroughAvailable: _isPciPassthroughAvailable, | ||
| mdadmHealthAvailable: mdadmHealth?.raid ? mdadmHealth : null, |
There was a problem hiding this comment.
mdadmHealthAvailable seems to indicate that we are expecting a boolean.
Suggested change
| mdadmHealthAvailable: mdadmHealth?.raid ? mdadmHealth : null, | |
| mdadmHealthAvailable: mdadmHealth != null ? true : false, |
| this.setState({ | ||
| isHtEnabled: await isHyperThreadingEnabledHost(host).catch(() => null), | ||
| isSmartctlHealthEnabled, | ||
| pciStateById, | ||
| smartctlUnhealthyDevices, | ||
| unhealthyDevicesAlerts, | ||
| isPciPassthroughAvailable: _isPciPassthroughAvailable, | ||
| mdadmHealthAvailable: mdadmHealth?.raid ? mdadmHealth : null, | ||
| mdadmState: mdadmHealth.raid?.State, |
There was a problem hiding this comment.
mdadmState: mdadmHealthAvailable ? mdadmHealth.raid?.State : undefined,
Comment on lines
+698
to
+703
| {mdadmHealthAvailable && ( | ||
| <tr> | ||
| <th>{_('raidStatus')}</th> | ||
| <td>{mdadmState === 'clean' || mdadmState === 'active' ? _('raidHealthy') : mdadmState}</td> | ||
| </tr> | ||
| )} |
There was a problem hiding this comment.
Avoid to hide information, add a message that explain "Why mdadmHealthAvailable is false".
It will probably depend of the mdadmHealth, but it can be plugin not installed, or no raid on the host
Comment on lines
+16
to
+17
| - [Host] In host and advanced view, display MDADM health information (PR [#8190](https://github.com/vatesfr/xen-orchestra/pull/8190)) | ||
|
|
There was a problem hiding this comment.
Suggested change
| - [Host] In host and advanced view, display MDADM health information (PR [#8190](https://github.com/vatesfr/xen-orchestra/pull/8190)) | |
| - [Host/Advanced] In host's advanced tab, display MDADM health information (PR [#8190](https://github.com/vatesfr/xen-orchestra/pull/8190)) | |
| return this.getXapi(host).getHostMdadmHealth(host._xapiId, { cache: CACHE_MDADM }) | ||
| } | ||
|
|
||
| getMdadmHealth.description = 'get mdadm health status' |
There was a problem hiding this comment.
get mdadm health status sound like it returns a simple string..
|
Additionally, the GH issue in the PR description does not seem relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #763
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.mdReview process
Notes: