Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backups): backup worker inspect failed: address already in use #8197

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stephane-m-dev
Copy link
Contributor

Description

When launching a backup worker, if using node inspector it fails since the port is already in use.

Starting inspector on 127.0.0.1:9229 failed: address already in use
2024-12-16T09:22:09.126Z xo:backups:worker INFO starting backup

This fix allows to use another port.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@stephane-m-dev stephane-m-dev force-pushed the backup-worker-inspect-on-another-port branch from 8c9ffd7 to 9152f6e Compare December 16, 2024 10:22
@stephane-m-dev stephane-m-dev changed the title fix(backups): backup worker inspect on another port fix(backups): backup worker inspect failed: address already in use Dec 16, 2024
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@b-Nollet b-Nollet requested a review from fbeauchamp December 16, 2024 13:50
@stephane-m-dev stephane-m-dev force-pushed the backup-worker-inspect-on-another-port branch from 041e9ed to ea511dd Compare December 16, 2024 14:23
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's the correct approach, what if there is multiple backup workers?

Any other solutions?

@stephane-m-dev
Copy link
Contributor Author

I don't think that's the correct approach, what if there is multiple backup workers?

Any other solutions?

We could test which ports are currently used, and increment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants