Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/support base reg #161

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PengBoUESTC
Copy link

if we add base config in mpa mode, the createRewire will not create a correct regex for url path, because connect-history-api-fallback use pathname to math the middleware regex, which value is base + xx.html

eg:

base: /testbase/

createRewire regex: for other.html is /^\/other.html*/

connect-history-api-fallback pathname for match is /testbase/other.html

@PengBoUESTC
Copy link
Author

for #162

@PengBoUESTC
Copy link
Author

@anncwb need review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant