Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new feature: Created Table Component #103

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Add new feature: Created Table Component #103

merged 4 commits into from
Oct 6, 2023

Conversation

shlok-2003
Copy link
Contributor

Resolves issue: #46

vczb
vczb reviewed Oct 5, 2023
View reviewed changes
Copy link
Owner

@vczb vczb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, please fix the styling approach and we can merge it 👍

src/packages/Table/style.ts Outdated Show resolved Hide resolved
@shlok-2003 shlok-2003 changed the title Add new feature: Table Component Add new feature: Added default theme to the styles.ts Oct 6, 2023
@shlok-2003 shlok-2003 changed the title Add new feature: Added default theme to the styles.ts Add new feature: Created Table Component Oct 6, 2023
vczb
vczb approved these changes Oct 6, 2023
View reviewed changes
Copy link
Owner

@vczb vczb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vczb vczb merged commit dd6ee36 into vczb:main Oct 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vczb vczb vczb approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shlok-2003 @vczb