-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable disconnection during non-IP-direct connection #2291
Conversation
Signed-off-by: kpango <[email protected]>
[CHATOPS:HELP] ChatOps commands.
|
Deploying with
|
Latest commit: |
f555a94
|
Status: | ✅ Deploy successful! |
Preview URL: | https://abca3555.vald.pages.dev |
Branch Preview URL: | https://refactor-internal-grpc-fix-c.vald.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2291 +/- ##
==========================================
- Coverage 29.96% 29.95% -0.01%
==========================================
Files 371 371
Lines 36152 36165 +13
==========================================
+ Hits 10833 10835 +2
- Misses 24804 24817 +13
+ Partials 515 513 -2 ☔ View full report in Codecov by Sentry. |
Let's merge after e2e passes just in case. |
Profile Report
|
Description:
Same as #2288
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: