Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ngt property get API #2584

Merged
merged 20 commits into from
Aug 22, 2024

add unit test

438b4a8
Select commit
Loading
Failed to load commit list.
Merged

Implement ngt property get API #2584

add unit test
438b4a8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 21, 2024 in 0s

24.53% (+7.15%) compared to 145b9cc

View this Pull Request on Codecov

24.53% (+7.15%) compared to 145b9cc

Details

Codecov Report

Attention: Patch coverage is 19.37984% with 208 lines in your changes missing coverage. Please review.

Project coverage is 24.53%. Comparing base (145b9cc) to head (438b4a8).

Files Patch % Lines
pkg/gateway/lb/handler/grpc/handler.go 0.00% 92 Missing ⚠️
internal/core/algorithm/ngt/ngt.go 43.95% 51 Missing ⚠️
pkg/agent/core/ngt/service/ngt.go 0.00% 40 Missing ⚠️
internal/client/v1/client/vald/vald.go 0.00% 21 Missing ⚠️
pkg/agent/core/ngt/handler/grpc/index.go 69.23% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2584      +/-   ##
==========================================
+ Coverage   17.37%   24.53%   +7.15%     
==========================================
  Files         566      530      -36     
  Lines       69218    45522   -23696     
==========================================
- Hits        12026    11167     -859     
+ Misses      56392    33604   -22788     
+ Partials      800      751      -49

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov