Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct distance_type lorentz value to match schema #2878

Merged
merged 4 commits into from
Mar 4, 2025
Merged

correct distance_type lorentz value to match schema #2878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f11e8c
correct distance_type lorentz value to match schema
irokaru Mar 2, 2025
a091427
fix constant value comment
irokaru Mar 3, 2025
d328996
Update internal/core/algorithm/ngt/option.go
irokaru Mar 3, 2025
adb6e15
Merge branch 'main' into bugfix/agent/cannot-choice-lorentz
vankichi Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/core/algorithm/ngt/ngt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ const (
Cosine
// Poincare is poincare distance.
Poincare
// Lorentz is lorenz distance.
// Lorentz is lorentz distance.
Lorentz
// Jaccard is jaccard distance.
Jaccard
Expand Down
2 changes: 1 addition & 1 deletion internal/core/algorithm/ngt/option.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
d = Cosine
case "poincare", "poinc", "poi", "po", "pc":
d = Poincare
case "lorenz", "loren", "lor", "lo", "lz":
case "lorentz", "lorent", "lorenz", "loren", "lor", "lo", "lz":

Check warning on line 126 in internal/core/algorithm/ngt/option.go

View check run for this annotation

Codecov / codecov/patch

internal/core/algorithm/ngt/option.go#L126 

Added line #L126 was not covered by tests
d = Lorentz
case "jaccard", "jac":
d = Jaccard
Expand Down
Loading