Support for TVScraper and VDR resumepoints #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can not test this myself as it is not just a compile fix and I don't use tvscraper and/or scraper2vdr on my setup and won't change my setup just to test combinations I'm not intending to use. I'm not the maintainer here either. Thanks for opening a discussion thread here: https://www.vdr-portal.de/forum/index.php?thread/135110-artwork-and-backend-resume-support-testers-needed/ This is where this feature now should be discussed first. Let's hope that some VDR users on VDR-Portal are interested in testing this. After some positive feedback I'll accept the Pull Request. |
repojohnray
added a commit
to repojohnray/vdr-plugin-vnsiserver
that referenced
this pull request
Jan 10, 2023
This was the reported error:
terminate called after throwing an instance of 'std::logic_error'
what(): basic_string::_M_construct null not valid
Here is a backtrace of std::__throw_logic_error():
#0 0x7f44aea2d919 in __sanitizer_print_stack_trace (/usr/lib64/libasan.so.6+0xbc919)
vdr-projects#1 0x7f44a23ac14e in void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>(char const*, char const*, std::forward_iterator_tag) /usr/include/c++/11.3.0/bits/basic_string.tcc:220
vdr-projects#2 0x7f44a23f1911 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string<std::allocator<char> >(char const*, std::allocator<char> const&) /usr/include/c++/11.3.0/bits/basic_string.h:539
vdr-projects#3 0x7f44a23f1911 in CVNSITimers::Action() vnsiserver-f90067db10973bac36ac59f7105523dd66c0dd55/vnsitimer.c:452
vdr-projects#4 0xd6314a in cThread::StartThread(cThread*) vdr-2.4.7/thread.c:293
vdr-projects#5 0x7f44ad9d4535 (/lib64/libc.so.6+0x85535)
vdr-projects#6 0x7f44ada56dfb (/lib64/libc.so.6+0x107dfb)
repojohnray
added a commit
to repojohnray/vdr-plugin-vnsiserver
that referenced
this pull request
Jan 13, 2023
This was the reported error:
terminate called after throwing an instance of 'std::logic_error'
what(): basic_string::_M_construct null not valid
Here is a backtrace of std::__throw_logic_error():
#0 0x7f44aea2d919 in __sanitizer_print_stack_trace (/usr/lib64/libasan.so.6+0xbc919)
vdr-projects#1 0x7f44a23ac14e in void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>(char const*, char const*, std::forward_iterator_tag) /usr/include/c++/11.3.0/bits/basic_string.tcc:220
vdr-projects#2 0x7f44a23f1911 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string<std::allocator<char> >(char const*, std::allocator<char> const&) /usr/include/c++/11.3.0/bits/basic_string.h:539
vdr-projects#3 0x7f44a23f1911 in CVNSITimers::Action() vnsiserver-f90067db10973bac36ac59f7105523dd66c0dd55/vnsitimer.c:452
vdr-projects#4 0xd6314a in cThread::StartThread(cThread*) vdr-2.4.7/thread.c:293
vdr-projects#5 0x7f44ad9d4535 (/lib64/libc.so.6+0x85535)
vdr-projects#6 0x7f44ada56dfb (/lib64/libc.so.6+0x107dfb)
Dis90
force-pushed
the
tvscraper_backendresume
branch
4 times, most recently
from
f6e6a99
to
161f5c1
Compare
Also have to bump protocol version
Dis90
force-pushed
the
tvscraper_backendresume
branch
from
161f5c1
to
1f54d53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also have to bump protocol version.
PR also opened to Kodi VNSI client: kodi-pvr/pvr.vdr.vnsi#180