Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AWS KMS for delegation #1435

Merged
merged 39 commits into from
Oct 29, 2024
Merged

feat: AWS KMS for delegation #1435

merged 39 commits into from
Oct 29, 2024

Conversation

freemanzMrojo
Copy link
Member

Description

This PR extends the usage of AWS KMS for delegation.

Closes #1413 .

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Using the existing test suite + new tests have created to target testnet for delegation url.

Test Configuration:

  • Node.js Version: 20.17.0
  • Yarn Version: 1.22.19

Checklist:

  • My code follows the coding standards of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing integration tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

Copy link

github-actions bot commented Oct 24, 2024

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 99%
99.06% (4338/4379) 97.71% (1413/1446) 99.11% (895/903)
Title Tests Skipped Failures Errors Time
core 808 0 💤 0 ❌ 0 🔥 2m 12s ⏱️
network 734 0 💤 0 ❌ 0 🔥 5m 5s ⏱️
errors 42 0 💤 0 ❌ 0 🔥 15.797s ⏱️

@freemanzMrojo freemanzMrojo marked this pull request as ready for review October 24, 2024 09:03
@freemanzMrojo freemanzMrojo requested a review from a team as a code owner October 24, 2024 09:03
Copy link
Member

@fabiorigam fabiorigam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just added a question

# awslocal kms create-key --key-usage SIGN_VERIFY --key-spec ECC_SECG_P256K1 --tags "[{\"TagKey\":\"_custom_key_material_\",\"TagValue\":\"$CUSTOM_ORIGIN_KEY_MATERIAL\"},{\"TagKey\":\"_custom_id_\",\"TagValue\":\"$CUSTOM_ORIGIN_ID\"}]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this command commented?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is because of this issue localstack/localstack#11678 . Basically nowadays we cannot import a custom key into localstack, but once the issue is fixed we should be able to do it with this commented-out line.

The command itself does not break but it does not import anything.

@freemanzMrojo freemanzMrojo merged commit 03dfd27 into main Oct 29, 2024
14 checks passed
@freemanzMrojo freemanzMrojo deleted the feat/1413-aws-kms-delegator branch October 29, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 [REQUEST] - Add delegator configuration for AWS KMS
2 participants