-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: AWS KMS for delegation #1435
Conversation
… feat/1413-aws-kms-delegator
… feat/1413-aws-kms-delegator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just added a question
# awslocal kms create-key --key-usage SIGN_VERIFY --key-spec ECC_SECG_P256K1 --tags "[{\"TagKey\":\"_custom_key_material_\",\"TagValue\":\"$CUSTOM_ORIGIN_KEY_MATERIAL\"},{\"TagKey\":\"_custom_id_\",\"TagValue\":\"$CUSTOM_ORIGIN_ID\"}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this command commented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is because of this issue localstack/localstack#11678 . Basically nowadays we cannot import a custom key into localstack, but once the issue is fixed we should be able to do it with this commented-out line.
The command itself does not break but it does not import anything.
Description
This PR extends the usage of AWS KMS for delegation.
Closes #1413 .
Type of change
How Has This Been Tested?
Using the existing test suite + new tests have created to target testnet for delegation url.
Test Configuration:
Checklist: