Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish rpc-proxy Dockerfile on tag #1454

Merged
merged 14 commits into from
Nov 4, 2024

Conversation

freemanzMrojo
Copy link
Member

@freemanzMrojo freemanzMrojo commented Oct 31, 2024

Description

As part of the release, when creating a tag we will publish in Docker Hub the rpc-proxy image named vechain/sdk-rpc-proxy.

This is one of the steps needed to complete #1319 .

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

By running the pipeline for the PR. It is possible though that the pipeline could break the first time when creating the tag.

Test Configuration:

  • Node.js Version: 20.17.0
  • Yarn Version: 1.22.19

Checklist:

  • My code follows the coding standards of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing integration tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

Copy link

github-actions bot commented Oct 31, 2024

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 99%
99.06% (4352/4393) 97.71% (1413/1446) 99.11% (896/904)
Title Tests Skipped Failures Errors Time
core 808 0 💤 0 ❌ 0 🔥 2m 21s ⏱️
network 734 0 💤 0 ❌ 0 🔥 5m 14s ⏱️
errors 42 0 💤 0 ❌ 0 🔥 16.696s ⏱️
logging 3 0 💤 0 ❌ 0 🔥 17.211s ⏱️
hardhat-plugin 19 0 💤 0 ❌ 0 🔥 59.412s ⏱️
aws-kms-adapter 23 0 💤 0 ❌ 0 🔥 1m 16s ⏱️
ethers-adapter 5 0 💤 0 ❌ 0 🔥 1m 11s ⏱️
rpc-proxy 37 0 💤 0 ❌ 0 🔥 1m 6s ⏱️

@freemanzMrojo freemanzMrojo changed the title [DRAFT] Feat/1319 publish rpc proxy dockerfile feat: publish rpc-proxy Dockerfile Oct 31, 2024
@freemanzMrojo freemanzMrojo changed the title feat: publish rpc-proxy Dockerfile feat: publish rpc-proxy Dockerfile on tag Oct 31, 2024
@freemanzMrojo freemanzMrojo marked this pull request as ready for review October 31, 2024 12:55
@freemanzMrojo freemanzMrojo requested a review from a team as a code owner October 31, 2024 12:55
@freemanzMrojo freemanzMrojo merged commit c02b2ff into main Nov 4, 2024
14 checks passed
@freemanzMrojo freemanzMrojo deleted the feat/1319-publish-rpc-proxy-dockerfile branch November 4, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants