Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint security plugin #1470

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Add eslint security plugin #1470

merged 4 commits into from
Nov 6, 2024

Conversation

fabiorigam
Copy link
Member

No description provided.

@fabiorigam fabiorigam requested a review from a team as a code owner November 5, 2024 14:03
@fabiorigam fabiorigam linked an issue Nov 5, 2024 that may be closed by this pull request
Fix the eslint-plugin-security lint issues #1463
Closed
@socket-security Socket Security
Copy link

socket-security bot commented Nov 5, 2024 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 140 kB eslint-community-bot
npm/[email protected] None 0 314 kB dmitrysoshnikov
npm/[email protected] None 0 16.5 kB davisjam

View full report↗︎

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024 •
edited
Loading

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 99%
 98.97% (4358/4403) 97.68% (1395/1428) 99% (897/906)
Title Tests Skipped Failures Errors Time
core 808 0 💤 0 ❌ 0 🔥 2m 17s ⏱️
network 723 0 💤 0 ❌ 0 🔥 4m 54s ⏱️
errors 42 0 💤 0 ❌ 0 🔥 16.384s ⏱️
logging 3 0 💤 0 ❌ 0 🔥 17.539s ⏱️
hardhat-plugin 19 0 💤 0 ❌ 0 🔥 54.371s ⏱️
aws-kms-adapter 23 0 💤 0 ❌ 0 🔥 1m 24s ⏱️
ethers-adapter 5 0 💤 0 ❌ 0 🔥 1m 9s ⏱️
rpc-proxy 37 0 💤 0 ❌ 0 🔥 1m 1s ⏱️

@leszek-vechain
Copy link
Collaborator

seems like it shows warnings in CI too

@fabiorigam fabiorigam merged commit a7f3786 into main Nov 6, 2024
14 checks passed
@fabiorigam fabiorigam deleted the 1463-fix-the-eslint-plugin-security-lint-issues branch November 6, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leszek-vechain leszek-vechain leszek-vechain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the eslint-plugin-security lint issues
2 participants
@fabiorigam @leszek-vechain