1450 thor client fix circular dependencies

[lucanicoladebiasi]

Description

The code refactors the ThorClient to avoid circular dependencies among the modules composing the Thor client.

Fixes #1450

Type of change

Please delete options that are not relevant.

• Bug fix
• This change required a documentation update: the ThorClient structure is shown at https://github.com/vechain/vechain-sdk-js/blob/1450-thor-client-fix-circular-dependencies/docs/diagrams/architecture/thor-client.md

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• yarn test:examples
• yarn test:solo
• yarn test:unit

Test Configuration:

• Node.js Version: v23.1.0
• Yarn Version: 1.22.22

Checklist:

[github-actions]

Test Coverage

Summary

Lines	Statements	Branches	Functions
	98.99% (4345/4389)	97.53% (1387/1422)	98.9% (901/911)

Title	Tests	Skipped	Failures	Errors	Time
core	827	0 💤	0 ❌	0 🔥	2m 19s ⏱️
network	719	0 💤	0 ❌	0 🔥	4m 59s ⏱️
errors	42	0 💤	0 ❌	0 🔥	16.866s ⏱️
logging	3	0 💤	0 ❌	0 🔥	18.588s ⏱️
hardhat-plugin	19	0 💤	0 ❌	0 🔥	1m 0s ⏱️
aws-kms-adapter	23	0 💤	0 ❌	0 🔥	1m 8s ⏱️
ethers-adapter	5	0 💤	0 ❌	0 🔥	1m 11s ⏱️
rpc-proxy	37	0 💤	0 ❌	0 🔥	1m 2s ⏱️

[freemanzMrojo]

Hi @lucanicoladebiasi , I think we should modify the script at package.json that counts the number of circular dependencies to validate that indeed they are going down (as of now it counts up to 11).

The script is check:circular-dependencies at network's package.json 👍

[lucanicoladebiasi]

Hi @lucanicoladebiasi , I think we should modify the script at package.json that counts the number of circular dependencies to validate that indeed they are going down (as of now it counts up to 11).

The script is check:circular-dependencies at network's package.json 👍

I modified the script as

 "check:circular-dependencies": "npx madge --json --circular --extensions ts src | jq '. | length' | awk '{if($1 > 0) exit 1}'"

and it doesn't complain anymore.

[freemanzMrojo]

Hi @lucanicoladebiasi , I think we should modify the script at package.json that counts the number of circular dependencies to validate that indeed they are going down (as of now it counts up to 11).
The script is check:circular-dependencies at network's package.json 👍

I modified the script as

 "check:circular-dependencies": "npx madge --json --circular --extensions ts src | jq '. | length' | awk '{if($1 > 0) exit 1}'"

and it doesn't complain anymore.

Nice! If we have 0 we could just run npx madge --circular --extensions ts src without the rest, like we do in package.jsonat core 👍

[freemanzMrojo]

LGTM, now looks much nicer, thanks!

Left some minor suggestions, regarding the constructor we could do the same also for nodes-module and transactions-module since looks like all args are readonly 👍