Skip to content

Commit

Permalink
fix(journald source): Fix event metrics reporting (#8163)
Browse files Browse the repository at this point in the history
The `instrument()` call here was replacing the span. I think we could
have made a nested span instead, and preserved the labels, but I don't
see a reason to have this span here since the component already has its
own span.

Signed-off-by: Jesse Szwedko <[email protected]>
  • Loading branch information
jszwedko authored Jul 8, 2021
1 parent 8cffc4a commit b101787
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/sources/journald.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ use tokio::{
process::Command,
time::sleep,
};
use tracing_futures::Instrument;

const DEFAULT_BATCH_SIZE: usize = 16;

Expand Down Expand Up @@ -143,8 +142,7 @@ impl SourceConfig for JournaldConfig {
remap_priority: self.remap_priority,
out: cx.out,
}
.run_shutdown(cx.shutdown, start)
.instrument(info_span!("journald-server")),
.run_shutdown(cx.shutdown, start),
))
}

Expand Down

0 comments on commit b101787

Please sign in to comment.