Skip to content

Commit

Permalink
chore(ci): Fix review comment trigger context (#21010)
Browse files Browse the repository at this point in the history
It is `github.event` not `github.events`

Signed-off-by: Jesse Szwedko <[email protected]>
  • Loading branch information
jszwedko committed Aug 6, 2024
1 parent 210ff09 commit f1a1e1c
Show file tree
Hide file tree
Showing 11 changed files with 36 additions and 36 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci-integration-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:
- name: (PR review) Set latest commit status as pending
uses: myrotvorets/[email protected]
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
status: pending

Expand All @@ -87,7 +87,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: "recursive"
ref: ${{ github.events.review.commit_id }}
ref: ${{ github.event.review.commit_id }}

- run: sudo npm -g install @datadog/datadog-ci

Expand Down Expand Up @@ -466,7 +466,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: "recursive"
ref: ${{ github.events.review.commit_id }}
ref: ${{ github.event.review.commit_id }}

- run: sudo npm -g install @datadog/datadog-ci

Expand Down Expand Up @@ -521,7 +521,7 @@ jobs:
if: github.event_name == 'pull_request_review' && env.FAILED != 'true'
uses: myrotvorets/[email protected]
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
status: 'success'

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/cli.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
if: ${{ github.event_name == 'pull_request_review' }}
uses: myrotvorets/[email protected]
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
context: CLI - Linux
status: pending
Expand All @@ -23,7 +23,7 @@ jobs:
if: ${{ github.event_name == 'pull_request_review' }}
uses: actions/checkout@v3
with:
ref: ${{ github.events.review.commit_id }}
ref: ${{ github.event.review.commit_id }}

- name: Checkout branch
if: ${{ github.event_name != 'pull_request_review' }}
Expand Down Expand Up @@ -53,7 +53,7 @@ jobs:
uses: myrotvorets/[email protected]
if: always() && github.event_name == 'pull_request_review'
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
context: CLI - Linux
status: ${{ job.status }}
6 changes: 3 additions & 3 deletions .github/workflows/component_features.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
if: github.event_name == 'pull_request_review'
uses: myrotvorets/[email protected]
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
context: Component Features - Linux
status: pending
Expand All @@ -35,7 +35,7 @@ jobs:
if: github.event_name == 'pull_request_review'
uses: actions/checkout@v3
with:
ref: ${{ github.events.review.commit_id }}
ref: ${{ github.event.review.commit_id }}

- name: Checkout branch
if: github.event_name != 'pull_request_review'
Expand All @@ -50,7 +50,7 @@ jobs:
if: always() && github.event_name == 'pull_request_review'
uses: myrotvorets/[email protected]
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
context: Component Features - Linux
status: ${{ job.status }}
6 changes: 3 additions & 3 deletions .github/workflows/cross.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
if: ${{ github.event_name == 'pull_request_review' }}
uses: myrotvorets/[email protected]
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
context: Cross
status: pending
Expand All @@ -35,7 +35,7 @@ jobs:
if: ${{ github.event_name == 'pull_request_review' }}
uses: actions/checkout@v3
with:
ref: ${{ github.events.review.commit_id }}
ref: ${{ github.event.review.commit_id }}

- name: Checkout branch
if: ${{ github.event_name != 'pull_request_review' }}
Expand Down Expand Up @@ -83,7 +83,7 @@ jobs:
- name: (PR review) Submit PR result as success
uses: myrotvorets/[email protected]
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
context: Cross
status: 'success'
6 changes: 3 additions & 3 deletions .github/workflows/deny.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
if: ${{ github.event_name == 'pull_request_review' }}
uses: myrotvorets/[email protected]
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
context: Deny - Linux
status: pending
Expand All @@ -36,7 +36,7 @@ jobs:
if: ${{ github.event_name == 'pull_request_review' }}
uses: actions/checkout@v3
with:
ref: ${{ github.events.review.commit_id }}
ref: ${{ github.event.review.commit_id }}

- name: Checkout branch
if: ${{ github.event_name != 'pull_request_review' }}
Expand Down Expand Up @@ -64,7 +64,7 @@ jobs:
uses: myrotvorets/[email protected]
if: always() && github.event_name == 'pull_request_review'
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
context: Deny - Linux
status: ${{ job.status }}
6 changes: 3 additions & 3 deletions .github/workflows/environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
if: ${{ github.event_name == 'pull_request_review' }}
uses: myrotvorets/[email protected]
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
context: Environment Suite
status: pending
Expand All @@ -29,7 +29,7 @@ jobs:
if: ${{ github.event_name == 'pull_request_review' }}
uses: actions/checkout@v3
with:
ref: ${{ github.events.review.commit_id }}
ref: ${{ github.event.review.commit_id }}

- name: Checkout branch
if: ${{ github.event_name != 'pull_request_review' }}
Expand Down Expand Up @@ -71,7 +71,7 @@ jobs:
uses: myrotvorets/[email protected]
if: always() && github.event_name == 'pull_request_review'
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
context: Environment Suite
status: ${{ job.status }}
10 changes: 5 additions & 5 deletions .github/workflows/k8s_e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,15 @@ jobs:
if: ${{ github.event_name == 'pull_request_review' }}
uses: myrotvorets/[email protected]
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
status: pending

- name: (PR review) Checkout PR branch
if: ${{ github.event_name == 'pull_request_review' }}
uses: actions/checkout@v3
with:
ref: ${{ github.events.review.commit_id }}
ref: ${{ github.event.review.commit_id }}

- name: Checkout branch
if: ${{ github.event_name != 'pull_request_review' }}
Expand All @@ -109,7 +109,7 @@ jobs:
uses: myrotvorets/[email protected]
if: failure() && github.event_name == 'pull_request_review'
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
status: 'failure'

Expand Down Expand Up @@ -224,7 +224,7 @@ jobs:
uses: myrotvorets/[email protected]
if: failure() && github.event_name == 'pull_request_review'
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
status: 'failure'

Expand All @@ -250,7 +250,7 @@ jobs:
if: github.event_name == 'pull_request_review' && env.FAILED != 'true'
uses: myrotvorets/[email protected]
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
status: 'success'

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/misc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
if: ${{ github.event_name == 'pull_request_review' }}
uses: myrotvorets/[email protected]
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
context: Miscellaneous - Linux
status: pending
Expand All @@ -23,7 +23,7 @@ jobs:
if: ${{ github.event_name == 'pull_request_review' }}
uses: actions/checkout@v3
with:
ref: ${{ github.events.review.commit_id }}
ref: ${{ github.event.review.commit_id }}

- name: Checkout branch
if: ${{ github.event_name != 'pull_request_review' }}
Expand Down Expand Up @@ -52,7 +52,7 @@ jobs:
uses: myrotvorets/[email protected]
if: always() && github.event_name == 'pull_request_review'
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
context: Miscellaneous - Linux
status: ${{ job.status }}
6 changes: 3 additions & 3 deletions .github/workflows/regression.yml
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ jobs:
if: ${{ github.event_name == 'pull_request_review' }}
uses: myrotvorets/[email protected]
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
context: Regression Detection Suite
status: pending
Expand Down Expand Up @@ -757,7 +757,7 @@ jobs:
if: github.event_name == 'pull_request_review' && env.FAILED == 'true'
uses: myrotvorets/[email protected]
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
context: Regression Detection Suite
status: 'failure'
Expand All @@ -766,7 +766,7 @@ jobs:
if: github.event_name == 'pull_request_review' && env.FAILED != 'true'
uses: myrotvorets/[email protected]
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
context: Regression Detection Suite
status: 'success'
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/unit_mac.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
if: ${{ github.event_name == 'pull_request_review' }}
uses: myrotvorets/[email protected]
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
context: Unit - Mac
status: pending
Expand All @@ -23,7 +23,7 @@ jobs:
if: ${{ github.event_name == 'pull_request_review' }}
uses: actions/checkout@v3
with:
ref: ${{ github.events.review.commit_id }}
ref: ${{ github.event.review.commit_id }}

- name: Checkout branch
if: ${{ github.event_name != 'pull_request_review' }}
Expand Down Expand Up @@ -51,7 +51,7 @@ jobs:
uses: myrotvorets/[email protected]
if: always() && github.event_name == 'pull_request_review'
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
context: Unit - Mac
status: ${{ job.status }}
6 changes: 3 additions & 3 deletions .github/workflows/unit_windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
if: ${{ github.event_name == 'pull_request_review' }}
uses: myrotvorets/[email protected]
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
context: Unit - Windows
status: pending
Expand All @@ -22,7 +22,7 @@ jobs:
if: ${{ github.event_name == 'pull_request_review' }}
uses: actions/checkout@v3
with:
ref: ${{ github.events.review.commit_id }}
ref: ${{ github.event.review.commit_id }}

- name: Checkout branch
if: ${{ github.event_name != 'pull_request_review' }}
Expand All @@ -35,7 +35,7 @@ jobs:
uses: myrotvorets/[email protected]
if: always() && github.event_name == 'pull_request_review'
with:
sha: ${{ github.events.review.commit_id }}
sha: ${{ github.event.review.commit_id }}
token: ${{ secrets.GITHUB_TOKEN }}
context: Unit - Windows
status: ${{ job.status }}

0 comments on commit f1a1e1c

Please sign in to comment.