Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector YAML configuration - anchors support #20853

Open
nazarovkv opened this issue Jul 14, 2024 · 7 comments · May be fixed by #21731
Open

Vector YAML configuration - anchors support #20853

nazarovkv opened this issue Jul 14, 2024 · 7 comments · May be fixed by #21731
Labels
domain: config Anything related to configuring Vector type: feature A value-adding code addition that introduce new functionality.

Comments

@nazarovkv
Copy link

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Use Cases

During configuration of Vector pipeline in YAML format - I've found that vector does not "understand" anchors features in YAML syntax.
I think it will be quite useful to define some templates for i.e. sinks and re-use it.
Let say - I need to route message to same kafka cluster, but to different topics - providing full configuration for each sink with only difference in topic name - can result in vector's config becoming fat.

Attempted Solutions

No response

Proposal

Figure 1 - Vector config in YAML format with multiple sinks to same kafka cluster:

sinks:
  kafka-topic-1:
    type: kafka
    bootstrap_servers: bootstrap-server-1.example.org, bootstrap-server-2.example.org, bootstrap-server-3.example.org
    sasl:
      enabled: true
      mechanism: "PLAIN"
      username: "kafka-username"
      password: "kafka-user-password"
    encoding:
      codec: json
    topic: topic-1
    inputs:
      - my-router.topic-1
  kafka-topic-2:
    type: kafka
    bootstrap_servers: bootstrap-server-1.example.org, bootstrap-server-2.example.org, bootstrap-server-3.example.org
    sasl:
      enabled: true
      mechanism: "PLAIN"
      username: "kafka-username"
      password: "kafka-user-password"
    encoding:
      codec: json
    topic: topic-2
    inputs:
      - my-router.topic-2
  kafka-topic-3:
    type: kafka
    bootstrap_servers: bootstrap-server-1.example.org, bootstrap-server-2.example.org, bootstrap-server-3.example.org
    sasl:
      enabled: true
      mechanism: "PLAIN"
      username: "kafka-username"
      password: "kafka-user-password"
    encoding:
      codec: json
    topic: topic-3
    inputs:
      - my-router.topic-3

Figure 2 - same config as above but with anchors:

templates:
  kafka-sink-tpl: &kafka-sink
    type: kafka
    bootstrap_servers: bootstrap-server-1.example.org, bootstrap-server-2.example.org, bootstrap-server-3.example.org
    sasl:
      enabled: true
      mechanism: "PLAIN"
      username: "kafka-username"
      password: "kafka-user-password"
    encoding:
      codec: json

sinks:
  kafka-topic-1:
    <<: *kafka-sink
    topic: topic-1
    inputs:
      - my-router.topic-1
  kafka-topic-2:
    <<: *kafka-sink
    topic: topic-2
    inputs:
      - my-router.topic-2
  kafka-topic-3:
    <<: *kafka-sink
    topic: topic-3
    inputs:
      - my-router.topic-3

Feel the difference.

References

No response

Version

No response

@nazarovkv nazarovkv added the type: feature A value-adding code addition that introduce new functionality. label Jul 14, 2024
@nazarovkv
Copy link
Author

Close pls. Found solution. https://vector.dev/docs/reference/configuration/template-syntax/

@frankh
Copy link
Contributor

frankh commented Aug 1, 2024

templating is clunky at best for this kind of thing, i think this should be re opened

@jszwedko
Copy link
Member

jszwedko commented Aug 1, 2024

Agreed, anchor support would be useful. Let me reopen this. Unfortunately I also don't expect it to happen anytime soon because the issue on the YAML parsing library that we use has been open since 2022: dtolnay/serde-yaml#317 (and the maintainer has stepped away from that project).

@jszwedko jszwedko reopened this Aug 1, 2024
@jszwedko jszwedko added the domain: config Anything related to configuring Vector label Aug 1, 2024
@jszwedko
Copy link
Member

jszwedko commented Aug 1, 2024

As a workaround, the configuration file could be pre-processed to expand the anchors. For example, yq can do this via cat vector.yaml | yq 'explode(.)'.

@nazarovkv
Copy link
Author

nazarovkv commented Aug 19, 2024

As a workaround, the configuration file could be pre-processed to expand the anchors. For example, yq can do this via cat vector.yaml | yq 'explode(.)'.

Hi @jszwedko, it can be useful right, but need to take one moment into account:
Let say, templates defined under templates key(just like a reported)

templates:
  kafka-sink-tpl: &kafka-sink
    type: kafka
    bootstrap_servers: bootstrap-server-1.example.org, bootstrap-server-2.example.org, bootstrap-server-3.example.org
    sasl:
      enabled: true
      mechanism: "PLAIN"
      username: "kafka-username"
      password: "kafka-user-password"
    encoding:
      codec: json

sinks:
  kafka-topic-1:
    <<: *kafka-sink
    topic: topic-1
    inputs:
      - my-router.topic-1
  kafka-topic-2:
    <<: *kafka-sink
    topic: topic-2
    inputs:
      - my-router.topic-2
  kafka-topic-3:
    <<: *kafka-sink
    topic: topic-3
    inputs:
      - my-router.topic-3

If I do cat vector.yaml | yq 'explode(.)'
it results in:

templates:
  kafka-sink-tpl:
    type: kafka
    bootstrap_servers: bootstrap-server-1.example.org, bootstrap-server-2.example.org, bootstrap-server-3.example.org
    sasl:
      enabled: true
      mechanism: "PLAIN"
      username: "kafka-username"
      password: "kafka-user-password"
    encoding:
      codec: json
sinks:
  kafka-topic-1:
    type: kafka
    bootstrap_servers: bootstrap-server-1.example.org, bootstrap-server-2.example.org, bootstrap-server-3.example.org
    sasl:
      enabled: true
      mechanism: "PLAIN"
      username: "kafka-username"
      password: "kafka-user-password"
    encoding:
      codec: json
    topic: topic-1
    inputs:
      - my-router.topic-1
  kafka-topic-2:
    type: kafka
    bootstrap_servers: bootstrap-server-1.example.org, bootstrap-server-2.example.org, bootstrap-server-3.example.org
    sasl:
      enabled: true
      mechanism: "PLAIN"
      username: "kafka-username"
      password: "kafka-user-password"
    encoding:
      codec: json
    topic: topic-2
    inputs:
      - my-router.topic-2
  kafka-topic-3:
    type: kafka
    bootstrap_servers: bootstrap-server-1.example.org, bootstrap-server-2.example.org, bootstrap-server-3.example.org
    sasl:
      enabled: true
      mechanism: "PLAIN"
      username: "kafka-username"
      password: "kafka-user-password"
    encoding:
      codec: json
    topic: topic-3
    inputs:
      - my-router.topic-3

So that templates key is kept in resulting config and hence vector will not start since vector knows nothing about templates key in vector.yaml.
To overcome this - need to run cat vector.yaml | yq 'explode(.), del(.templates)' - to remove unused key from vector.yaml

But anyway - I think original request will be useful, I still need this feature in some cases.😅

@jszwedko
Copy link
Member

I think that behavior is true, that templates would be in the resulting config, regardless of whether Vector handles the anchors or you preprocess with yq. It sounds like you what you want is for a way to have a dummy key that Vector ignores that you could use for declaring YAML aliases. I could see that being useful.

@nazarovkv
Copy link
Author

nazarovkv commented Aug 20, 2024

It sounds like you what you want is for a way to have a dummy key that Vector ignores that you could use for declaring YAML aliases. I could see that being useful.

Yeah, having such a special key for templating could solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: config Anything related to configuring Vector type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants