-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(elasticsearch sink): Support Amazon OpenSearch Serverless #21676
Conversation
|
Thanks for the credit! Great work! |
Docs are in; I think this one is completely ready for review! 🙇🏻 |
Hi @handlerbot, thank you and I will take a look shortly. |
@rtrieu Sent it over to you for docs re-review. The Check Spelling test is failing because today after a UPDATE[0]: I decided to just replace UPDATE[1]: I guess it's these, which are all about extra dictionaries that can't be downloaded, or non-alpha entries in the dictionary? Those are definitely not from anything I did in this! 😹
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @handlerbot!
@pront Pushed a commit from |
Apologies, the spell checker was broken. Please undo the spell checker related changes, rebase on latest master and push again to get a fresh report. |
@pront Ready! |
@pront If you're working today, could I get a quick re-approve on this? It would be awesome for our internal velocity if I could get this into the next vector release, and it feels like that might be sooner rather than later. 🤞🏻🙇🏻 🚀 |
Hi @handlerbot, I am doing a final pass now. We have plenty of time till the next Vector release ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I appreciate the good documentation in this PR.
@pront TYVM for the compliment, and thank you for the thorough and prompt review! 🙇🏻 Do we need any additional approvals re: documentation or other, or is this ready to be merged at next working time? |
All good, now merged. |
Thank you @pront and @rtrieu for the reviews, and @AvihaiSam for starting this out! 🌟 |
The new `service_type` is only used for OpenSearch AWS authentication. Follow-up to #21676 Signed-off-by: Jesse Szwedko <[email protected]>
The new `service_type` is only used for OpenSearch AWS authentication. Follow-up to #21676 Signed-off-by: Jesse Szwedko <[email protected]>
Summary
The elasticsearch sink can now write to Amazon OpenSearch Serverless collections by signing requests with AWS Signature V4 algorithm, specifying the
aoss
service.Change Type
Is this a breaking change?
How did you test this PR?
Stood up an Amazon OpenSearch Serverless collection, configured
vector
to send any files in a test directory to an index in that collection, verified they were written successfully by querying the index stats and the index itself.Does this PR include user facing changes?
Checklist
References
elasticsearch
sink #16252