Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Revert bump of flate2 from 1.0.27 to 1.0.28 (#18850) #20022

Closed
wants to merge 1 commit into from

Conversation

jszwedko
Copy link
Member

@jszwedko jszwedko commented Mar 6, 2024

This reverts commit b3889bc.

Testing to see if this changes performance.

This reverts commit b3889bc.

Testing to see if this changes performance.
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Mar 6, 2024
@jszwedko
Copy link
Member Author

jszwedko commented Mar 6, 2024

/ci-run-regression

Copy link

github-actions bot commented Mar 6, 2024

Your preview site for the VRL Playground will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
VRL Playground preview

Copy link

github-actions bot commented Mar 6, 2024

Your preview site for the Rust Doc will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
Rust Doc preview

Copy link

github-actions bot commented Mar 6, 2024

Regression Detector Results

Run ID: ef184768-a55e-405a-9eea-4523969722f8
Baseline: eb30996
Comparison: 6a881fc
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

perf experiment goal Δ mean % Δ mean % CI
otlp_http_to_blackhole ingress throughput +5.15 [+4.98, +5.32]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
otlp_http_to_blackhole ingress throughput +5.15 [+4.98, +5.32]
datadog_agent_remap_datadog_logs_acks ingress throughput +1.99 [+1.91, +2.08]
splunk_hec_route_s3 ingress throughput +1.73 [+1.21, +2.24]
fluent_elasticsearch ingress throughput +1.62 [+1.15, +2.10]
datadog_agent_remap_datadog_logs ingress throughput +0.94 [+0.84, +1.05]
socket_to_socket_blackhole ingress throughput +0.79 [+0.72, +0.87]
file_to_blackhole egress throughput +0.51 [-1.95, +2.98]
http_to_http_acks ingress throughput +0.45 [-0.87, +1.77]
syslog_log2metric_humio_metrics ingress throughput +0.24 [+0.12, +0.35]
datadog_agent_remap_blackhole_acks ingress throughput +0.22 [+0.11, +0.33]
otlp_grpc_to_blackhole ingress throughput +0.16 [+0.08, +0.25]
http_to_http_noack ingress throughput +0.14 [+0.04, +0.24]
http_to_s3 ingress throughput +0.03 [-0.26, +0.31]
http_to_http_json ingress throughput +0.01 [-0.07, +0.08]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.15, +0.15]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.14, +0.14]
syslog_humio_logs ingress throughput -0.03 [-0.13, +0.07]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.04 [-0.16, +0.08]
enterprise_http_to_http ingress throughput -0.12 [-0.20, -0.05]
http_elasticsearch ingress throughput -0.21 [-0.28, -0.13]
syslog_loki ingress throughput -0.25 [-0.31, -0.20]
datadog_agent_remap_blackhole ingress throughput -0.92 [-1.02, -0.82]
http_text_to_http_json ingress throughput -1.02 [-1.15, -0.89]
syslog_regex_logs2metric_ddmetrics ingress throughput -1.46 [-1.61, -1.31]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -2.10 [-2.26, -1.94]
syslog_log2metric_splunk_hec_metrics ingress throughput -2.49 [-2.64, -2.33]
syslog_splunk_hec_logs ingress throughput -2.80 [-2.88, -2.72]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@jszwedko jszwedko closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant