Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(releasing): Prepare v0.36.1 #20039

Closed
wants to merge 9 commits into from
Closed

chore(releasing): Prepare v0.36.1 #20039

wants to merge 9 commits into from

Conversation

jszwedko
Copy link
Member

@jszwedko jszwedko commented Mar 8, 2024

Checklist: #20038

@jszwedko jszwedko requested review from a team as code owners March 8, 2024 19:20
@jszwedko jszwedko requested a review from a team March 8, 2024 19:20
@jszwedko
Copy link
Member Author

jszwedko commented Mar 8, 2024

/ci-run-all

@github-actions github-actions bot added domain: sinks Anything related to the Vector's sinks domain: releasing Anything related to releasing Vector domain: external docs Anything related to Vector's external, public documentation labels Mar 8, 2024
StephenWakely and others added 7 commits March 8, 2024 11:28
@StephenWakely @jszwedko
fix (aws service): use http client so we can use openssl tls. (#19939)
a467715 
* Use http client so we can use openssl tls.

* Share connector code.

Signed-off-by: Stephen Wakely <[email protected]>

* Clippy

Signed-off-by: Stephen Wakely <[email protected]>

* Feedback from Bruce.

Signed-off-by: Stephen Wakely <[email protected]>

---------

Signed-off-by: Stephen Wakely <[email protected]>
@StephenWakely @jszwedko
fix(aws service): determine region using our http client (#19972)
9def84e 
* Use http client so we can use openssl tls.

* Share connector code.

Signed-off-by: Stephen Wakely <[email protected]>

* Clippy

Signed-off-by: Stephen Wakely <[email protected]>

* Feedback from Bruce.

Signed-off-by: Stephen Wakely <[email protected]>

* Resolve region with custom http provider.

Signed-off-by: Stephen Wakely <[email protected]>

---------

Signed-off-by: Stephen Wakely <[email protected]>
@jszwedko
chore(deps): Update lockfree-object-pool to 0.1.5 (#20001)
54bcee7 
We think this will fix #19627.

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko
chore(deps): Bump whoami to 1.5.0 (#20018)
e4951cc 
* chore(deps): Bump whoami to 1.5.0

Resolves RUSTSEC-2024-0020

Signed-off-by: Jesse Szwedko <[email protected]>

* regenerate licenses

Signed-off-by: Jesse Szwedko <[email protected]>

---------

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko
fix(aws provider): Enable credentials-process for aws-config (#20030
28760fb 
)

Otherwise it outputs this warning:

```
2024-03-07T11:59:25.573521Z  WARN provide_credentials{provider=default_chain}: aws_config::meta::credentials::chain: provider failed to provide credentials provider=Profile error=the credentials provider was not properly configured: ProfileFile provider could not be built: This behavior requires following cargo feature(s) enabled: credentials-process. In order to spawn a subprocess, the credentials-process feature must be enabled. (InvalidConfiguration(InvalidConfiguration { source: "ProfileFile provider could not be built: This behavior requires following cargo feature(s) enabled: credentials-process. In order to spawn a subprocess, the credentials-process feature must be enabled."
```

Signed-off-by: Jesse Szwedko <[email protected]>
@Hexta @jszwedko
fix(compression): Fix gzip and zlib performance degradation (#20032)
6313331 
* fix(compression): Fix gzip and zlib performance degradation

Fix gzip and zlib performance degradation caused by:
* flate2 v1.0.28 started to resize its input buffer up to its capacity
  and back to the actual number of bytes written.
* Some sinks are writing to Compressor without buffering,
  resulting in frequent small writes to the flate2 writer.
  Within 32KB of input buffer in flate2, this causes an excessive number of memset operations
  and degraded sink throughput.

This fix introduces a wrapper buffer in front of gzip and zlib writers to accumulate data
before calling the write function of the underlying writer.

Signed-off-by: Artur Malchanau <[email protected]>

* Add a link to the comment with more context.

---------

Signed-off-by: Artur Malchanau <[email protected]>
@jszwedko
chore(deps): Update mio (#20005)
a8cd2a2 
Resolves RUSTSEC-2024-0019

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko jszwedko force-pushed the prepare-v0.36.1 branch 2 times, most recently from 83e3625 to 622906e Compare March 8, 2024 19:34
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Mar 8, 2024
aliciascott
aliciascott approved these changes Mar 8, 2024
View reviewed changes
Copy link

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for docs

@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Mar 8, 2024 •
edited
Loading

Datadog Report

Branch report: prepare-v0.36.1
Commit report: 028b263
Test service: vector

✅ 0 Failed, 2333 Passed, 0 Skipped, 30m 9.52s Wall Time

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

Regression Detector Results

Run ID: 204df271-7643-4217-8369-56b79ac4b942
Baseline: 10f5d7d
Comparison: 82583d8
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
➖ syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +3.11 [+2.99, +3.23]
➖ syslog_splunk_hec_logs ingress throughput +2.81 [+2.75, +2.86]
➖ socket_to_socket_blackhole ingress throughput +2.70 [+2.62, +2.77]
➖ syslog_regex_logs2metric_ddmetrics ingress throughput +2.58 [+2.45, +2.72]
➖ syslog_loki ingress throughput +1.37 [+1.32, +1.43]
➖ datadog_agent_remap_datadog_logs ingress throughput +1.26 [+1.16, +1.37]
➖ syslog_log2metric_splunk_hec_metrics ingress throughput +0.68 [+0.52, +0.83]
➖ splunk_hec_route_s3 ingress throughput +0.66 [+0.17, +1.15]
➖ syslog_humio_logs ingress throughput +0.41 [+0.31, +0.52]
➖ datadog_agent_remap_blackhole ingress throughput +0.20 [+0.11, +0.29]
➖ datadog_agent_remap_datadog_logs_acks ingress throughput +0.19 [+0.11, +0.27]
➖ http_text_to_http_json ingress throughput +0.14 [+0.00, +0.28]
➖ http_to_http_noack ingress throughput +0.13 [+0.03, +0.22]
➖ http_to_http_json ingress throughput +0.07 [-0.01, +0.15]
➖ http_to_http_acks ingress throughput +0.05 [-1.27, +1.37]
➖ datadog_agent_remap_blackhole_acks ingress throughput +0.02 [-0.08, +0.12]
➖ splunk_hec_indexer_ack_blackhole ingress throughput +0.00 [-0.14, +0.14]
➖ splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.01 [-0.16, +0.15]
➖ http_to_s3 ingress throughput -0.01 [-0.30, +0.27]
➖ splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.02 [-0.14, +0.09]
➖ enterprise_http_to_http ingress throughput -0.12 [-0.18, -0.05]
➖ otlp_grpc_to_blackhole ingress throughput -0.30 [-0.39, -0.22]
➖ http_elasticsearch ingress throughput -0.50 [-0.56, -0.43]
➖ file_to_blackhole egress throughput -1.43 [-3.84, +0.98]
➖ otlp_http_to_blackhole ingress throughput -1.44 [-1.60, -1.29]
➖ fluent_elasticsearch ingress throughput -2.17 [-2.63, -1.71]
➖ syslog_log2metric_humio_metrics ingress throughput -2.21 [-2.32, -2.11]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@jszwedko
Copy link
Member Author

jszwedko commented Mar 8, 2024

/ci-run-all

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

Regression Detector Results

Run ID: 9548e3dc-0032-4bae-8624-f0dcf80f146c
Baseline: 10f5d7d
Comparison: 2857180
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
➖ syslog_humio_logs ingress throughput +3.04 [+2.94, +3.14]
➖ syslog_splunk_hec_logs ingress throughput +2.76 [+2.70, +2.82]
➖ file_to_blackhole egress throughput +2.51 [+0.03, +4.99]
➖ syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +2.47 [+2.32, +2.61]
➖ socket_to_socket_blackhole ingress throughput +1.82 [+1.74, +1.89]
➖ http_text_to_http_json ingress throughput +1.60 [+1.47, +1.73]
➖ datadog_agent_remap_datadog_logs_acks ingress throughput +1.16 [+1.08, +1.24]
➖ splunk_hec_route_s3 ingress throughput +0.94 [+0.44, +1.44]
➖ syslog_loki ingress throughput +0.82 [+0.76, +0.88]
➖ http_to_http_acks ingress throughput +0.82 [-0.49, +2.14]
➖ datadog_agent_remap_datadog_logs ingress throughput +0.62 [+0.53, +0.72]
➖ otlp_http_to_blackhole ingress throughput +0.31 [+0.15, +0.47]
➖ http_to_http_noack ingress throughput +0.17 [+0.08, +0.27]
➖ http_to_s3 ingress throughput +0.08 [-0.20, +0.36]
➖ http_to_http_json ingress throughput +0.02 [-0.06, +0.09]
➖ splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.16, +0.16]
➖ splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.15, +0.14]
➖ splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.01 [-0.12, +0.10]
➖ http_elasticsearch ingress throughput -0.05 [-0.12, +0.02]
➖ syslog_log2metric_splunk_hec_metrics ingress throughput -0.11 [-0.26, +0.03]
➖ enterprise_http_to_http ingress throughput -0.15 [-0.24, -0.06]
➖ otlp_grpc_to_blackhole ingress throughput -0.28 [-0.37, -0.20]
➖ syslog_log2metric_humio_metrics ingress throughput -0.61 [-0.73, -0.50]
➖ datadog_agent_remap_blackhole ingress throughput -0.77 [-0.86, -0.68]
➖ datadog_agent_remap_blackhole_acks ingress throughput -1.04 [-1.14, -0.93]
➖ fluent_elasticsearch ingress throughput -1.05 [-1.51, -0.59]
➖ syslog_regex_logs2metric_ddmetrics ingress throughput -1.57 [-1.65, -1.48]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@jszwedko
Copy link
Member Author

Merged locally to preserve commit history.

@jszwedko jszwedko closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliciascott aliciascott aliciascott approved these changes

@neuronull neuronull neuronull approved these changes

Assignees
No one assigned
Labels
domain: external docs Anything related to Vector's external, public documentation domain: releasing Anything related to releasing Vector domain: sinks Anything related to the Vector's sinks no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jszwedko @neuronull @aliciascott @StephenWakely @Hexta