Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(splunk hec): add semantic meaning for Vector log namespace #20292

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

pront
Copy link
Contributor

@pront pront commented Apr 12, 2024

No description provided.

@pront pront requested a review from a team as a code owner April 12, 2024 14:10
@github-actions github-actions bot added the domain: sources Anything related to the Vector's sources label Apr 12, 2024
@datadog-vectordotdev

This comment was marked as outdated.

@pront pront enabled auto-merge April 12, 2024 17:17
Copy link
Contributor

@vladimir-dd vladimir-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pront pront requested a review from jszwedko April 12, 2024 17:28
@pront pront disabled auto-merge April 12, 2024 17:28
@pront pront added this pull request to the merge queue Apr 12, 2024
@pront pront removed this pull request from the merge queue due to a manual request Apr 12, 2024
Copy link

Regression Detector Results

Run ID: c4c74d79-ce93-4395-864b-1d17bcbd4788
Baseline: 153919d
Comparison: 9c5d98f
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
syslog_splunk_hec_logs ingress throughput +3.70 [+3.59, +3.81]
splunk_hec_route_s3 ingress throughput +2.85 [+2.38, +3.32]
socket_to_socket_blackhole ingress throughput +0.81 [+0.76, +0.85]
syslog_loki ingress throughput +0.72 [+0.64, +0.81]
http_elasticsearch ingress throughput +0.45 [+0.38, +0.52]
otlp_grpc_to_blackhole ingress throughput +0.34 [+0.25, +0.43]
http_to_http_acks ingress throughput +0.32 [-1.03, +1.67]
http_to_http_noack ingress throughput +0.08 [-0.02, +0.17]
fluent_elasticsearch ingress throughput +0.04 [-0.44, +0.52]
http_to_http_json ingress throughput +0.04 [-0.04, +0.11]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +0.03 [-0.11, +0.17]
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.14, +0.14]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.15, +0.14]
datadog_agent_remap_datadog_logs ingress throughput -0.02 [-0.12, +0.09]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.02 [-0.13, +0.10]
datadog_agent_remap_blackhole_acks ingress throughput -0.03 [-0.14, +0.09]
enterprise_http_to_http ingress throughput -0.12 [-0.21, -0.03]
http_to_s3 ingress throughput -0.15 [-0.44, +0.13]
syslog_log2metric_splunk_hec_metrics ingress throughput -0.22 [-0.36, -0.09]
datadog_agent_remap_datadog_logs_acks ingress throughput -0.32 [-0.40, -0.23]
syslog_regex_logs2metric_ddmetrics ingress throughput -0.49 [-0.61, -0.38]
file_to_blackhole egress throughput -0.52 [-3.02, +1.97]
otlp_http_to_blackhole ingress throughput -0.54 [-0.67, -0.42]
syslog_log2metric_humio_metrics ingress throughput -0.75 [-0.91, -0.59]
http_text_to_http_json ingress throughput -1.10 [-1.23, -0.97]
datadog_agent_remap_blackhole ingress throughput -1.13 [-1.21, -1.04]
syslog_humio_logs ingress throughput -1.81 [-1.95, -1.67]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@pront pront added this pull request to the merge queue Apr 12, 2024
Copy link

Regression Detector Results

Run ID: dee81f97-ffc4-4e17-b980-dd425c82667f
Baseline: 153919d
Comparison: fae2ebf
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
datadog_agent_remap_datadog_logs ingress throughput +1.26 [+1.15, +1.38]
http_elasticsearch ingress throughput +1.25 [+1.17, +1.33]
syslog_humio_logs ingress throughput +1.23 [+1.06, +1.41]
socket_to_socket_blackhole ingress throughput +1.10 [+1.03, +1.17]
syslog_loki ingress throughput +1.07 [+0.98, +1.16]
otlp_http_to_blackhole ingress throughput +0.89 [+0.74, +1.04]
datadog_agent_remap_blackhole_acks ingress throughput +0.36 [+0.27, +0.46]
splunk_hec_route_s3 ingress throughput +0.22 [-0.25, +0.68]
http_text_to_http_json ingress throughput +0.20 [+0.08, +0.32]
http_to_http_noack ingress throughput +0.18 [+0.10, +0.27]
datadog_agent_remap_blackhole ingress throughput +0.06 [-0.03, +0.15]
http_to_http_json ingress throughput +0.04 [-0.03, +0.12]
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.14, +0.14]
splunk_hec_indexer_ack_blackhole ingress throughput -0.01 [-0.15, +0.14]
enterprise_http_to_http ingress throughput -0.03 [-0.09, +0.02]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.03 [-0.15, +0.08]
http_to_s3 ingress throughput -0.06 [-0.33, +0.22]
fluent_elasticsearch ingress throughput -0.28 [-0.76, +0.20]
otlp_grpc_to_blackhole ingress throughput -0.31 [-0.39, -0.22]
datadog_agent_remap_datadog_logs_acks ingress throughput -0.44 [-0.52, -0.36]
syslog_regex_logs2metric_ddmetrics ingress throughput -0.52 [-0.66, -0.38]
syslog_splunk_hec_logs ingress throughput -0.64 [-0.71, -0.57]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -0.87 [-1.00, -0.74]
http_to_http_acks ingress throughput -0.92 [-2.26, +0.42]
syslog_log2metric_humio_metrics ingress throughput -1.53 [-1.69, -1.38]
file_to_blackhole egress throughput -1.59 [-4.11, +0.92]
syslog_log2metric_splunk_hec_metrics ingress throughput -2.08 [-2.22, -1.94]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into master with commit fae2ebf Apr 12, 2024
51 checks passed
@pront pront deleted the pront/hec-sem-meaning branch April 12, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sources Anything related to the Vector's sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants