Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump chrono from 0.4.37 to 0.4.38 #20309

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 16, 2024

Bumps chrono from 0.4.37 to 0.4.38.

Release notes

Sourced from chrono's releases.

v0.4.38

This release bring a ca. 20% improvement to the performance of the formatting code, and a convenient days_since method for the Weekday type.

Chrono 0.4.38 also removes the long deprecated rustc-serialize feature. Support for rustc-serialize will be soft-destabilized in the next Rust edition. Removing the feature will not break existing users of the feature; Cargo will just not update dependents that rely on it to newer versions of chrono.

In chrono 0.4.36 we made an accidental breaking change by switching to derive(Copy) for DateTime instead of a manual implementation. It is reverted in this release.

Removals

Additions

Fixes

  • Return error when rounding with a zero duration (#1474, thanks @​Dav1dde)
  • Manually implement Copy for DateTime if offset is Copy (#1573)

Internal

  • Inline test_encodable_json and test_decodable_json functions (#1550)
  • CI: Reduce combinations in cargo hack check (#1553)
  • Refactor formatting code (#1335)
  • Optimize number formatting (#1558)
  • Only package files needed for building and testing (#1554)

Thanks to all contributors on behalf of the chrono team, @​djc and @​pitdicker!

Commits
  • 352a352 Prepare 0.4.38
  • 46d44d6 Manually implement Copy for DateTime if offset is Copy
  • 760eb66 Update windows-bindgen requirement from 0.55 to 0.56
  • 391187f Return error when rounding with zero duration
  • ffc75e5 Add TimeDelta::checked_mul and TimeDelta::checked_div
  • f8cecbe Make Weekday::num_days_from public, rename to days_since.
  • 0cfc405 Optimize number formatting
  • 74ba83b Take pad by value
  • 78e79db Match on tuples in format_fixed
  • f3d76c7 Match on tuples in format_numeric
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added domain: deps Anything related to Vector's dependencies no-changelog Changes in this PR do not need user-facing explanations in the release changelog labels Apr 16, 2024
@dependabot dependabot bot force-pushed the dependabot/cargo/chrono-0.4.38 branch 5 times, most recently from 828be19 to 0c43194 Compare April 22, 2024 18:25
@dependabot dependabot bot force-pushed the dependabot/cargo/chrono-0.4.38 branch 8 times, most recently from 903d0b1 to d6e8b94 Compare May 2, 2024 18:57
@dependabot dependabot bot force-pushed the dependabot/cargo/chrono-0.4.38 branch 6 times, most recently from f5560ff to 75fcc71 Compare May 10, 2024 18:49
@jszwedko
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/cargo/chrono-0.4.38 branch from 75fcc71 to e2458d9 Compare July 26, 2024 22:23
@dependabot dependabot bot requested a review from a team as a code owner July 26, 2024 22:23
Bumps [chrono](https://github.com/chronotope/chrono) from 0.4.37 to 0.4.38.
- [Release notes](https://github.com/chronotope/chrono/releases)
- [Changelog](https://github.com/chronotope/chrono/blob/main/CHANGELOG.md)
- [Commits](chronotope/chrono@v0.4.37...v0.4.38)

---
updated-dependencies:
- dependency-name: chrono
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/chrono-0.4.38 branch from e2458d9 to 6f157df Compare July 26, 2024 22:25
@jszwedko jszwedko enabled auto-merge July 26, 2024 23:04
@jszwedko jszwedko added this pull request to the merge queue Jul 26, 2024
Copy link

Regression Detector Results

Run ID: ff5a4913-4347-4a6f-97ee-9e8a49f2fc24 Metrics dashboard

Baseline: 9ece7a1
Comparison: 1b57be4

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI links
file_to_blackhole egress throughput -16.74 [-22.95, -10.53]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
syslog_regex_logs2metric_ddmetrics ingress throughput +4.01 [+3.85, +4.17]
datadog_agent_remap_blackhole ingress throughput +3.95 [+3.85, +4.06]
datadog_agent_remap_blackhole_acks ingress throughput +2.62 [+2.47, +2.76]
http_to_http_acks ingress throughput +1.06 [-0.26, +2.38]
otlp_http_to_blackhole ingress throughput +0.84 [+0.71, +0.98]
syslog_log2metric_humio_metrics ingress throughput +0.83 [+0.68, +0.97]
socket_to_socket_blackhole ingress throughput +0.74 [+0.64, +0.83]
http_to_s3 ingress throughput +0.57 [+0.30, +0.84]
otlp_grpc_to_blackhole ingress throughput +0.34 [+0.23, +0.45]
http_text_to_http_json ingress throughput +0.25 [+0.12, +0.38]
http_to_http_noack ingress throughput +0.15 [+0.07, +0.23]
http_to_http_json ingress throughput +0.04 [-0.00, +0.09]
splunk_hec_to_splunk_hec_logs_noack ingress throughput +0.01 [-0.08, +0.11]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.10, +0.11]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.08, +0.07]
datadog_agent_remap_datadog_logs_acks ingress throughput -0.60 [-0.80, -0.40]
fluent_elasticsearch ingress throughput -1.14 [-1.62, -0.65]
datadog_agent_remap_datadog_logs ingress throughput -1.21 [-1.38, -1.03]
syslog_splunk_hec_logs ingress throughput -1.27 [-1.37, -1.17]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -1.68 [-1.78, -1.58]
syslog_loki ingress throughput -1.78 [-1.86, -1.70]
syslog_log2metric_splunk_hec_metrics ingress throughput -1.84 [-1.95, -1.72]
splunk_hec_route_s3 ingress throughput -1.87 [-2.17, -1.56]
http_elasticsearch ingress throughput -2.46 [-2.64, -2.28]
syslog_humio_logs ingress throughput -2.60 [-2.74, -2.47]
file_to_blackhole egress throughput -16.74 [-22.95, -10.53]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Copy link

Regression Detector Results

Run ID: 912579b0-167b-4c9f-80c6-d52394a88cc2 Metrics dashboard

Baseline: 7f286c4
Comparison: 886f4e1

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI links
file_to_blackhole egress throughput -13.19 [-19.38, -7.00]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
http_to_http_acks ingress throughput +1.00 [-0.31, +2.32]
splunk_hec_route_s3 ingress throughput +0.73 [+0.40, +1.07]
http_to_http_noack ingress throughput +0.17 [+0.08, +0.25]
datadog_agent_remap_blackhole_acks ingress throughput +0.12 [+0.01, +0.23]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.10 [-0.06, +0.25]
http_to_http_json ingress throughput +0.04 [-0.00, +0.09]
otlp_grpc_to_blackhole ingress throughput +0.02 [-0.09, +0.13]
splunk_hec_to_splunk_hec_logs_noack ingress throughput +0.01 [-0.09, +0.11]
splunk_hec_indexer_ack_blackhole ingress throughput +0.01 [-0.07, +0.09]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.13, +0.13]
fluent_elasticsearch ingress throughput -0.01 [-0.49, +0.48]
syslog_log2metric_humio_metrics ingress throughput -0.17 [-0.31, -0.02]
syslog_log2metric_splunk_hec_metrics ingress throughput -0.19 [-0.30, -0.08]
http_to_s3 ingress throughput -0.32 [-0.60, -0.05]
http_elasticsearch ingress throughput -0.42 [-0.58, -0.26]
syslog_humio_logs ingress throughput -0.49 [-0.64, -0.34]
datadog_agent_remap_blackhole ingress throughput -0.70 [-0.79, -0.60]
syslog_loki ingress throughput -1.14 [-1.23, -1.06]
syslog_regex_logs2metric_ddmetrics ingress throughput -1.38 [-1.58, -1.18]
datadog_agent_remap_datadog_logs ingress throughput -1.59 [-1.82, -1.35]
socket_to_socket_blackhole ingress throughput -1.78 [-1.85, -1.72]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -2.16 [-2.26, -2.06]
otlp_http_to_blackhole ingress throughput -2.40 [-2.52, -2.27]
http_text_to_http_json ingress throughput -3.68 [-3.80, -3.57]
syslog_splunk_hec_logs ingress throughput -4.49 [-4.58, -4.40]
file_to_blackhole egress throughput -13.19 [-19.38, -7.00]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into master with commit 886f4e1 Jul 27, 2024
50 checks passed
@jszwedko jszwedko deleted the dependabot/cargo/chrono-0.4.38 branch July 27, 2024 05:16
ym pushed a commit to ym/vector that referenced this pull request Aug 18, 2024
Bumps [chrono](https://github.com/chronotope/chrono) from 0.4.37 to 0.4.38.
- [Release notes](https://github.com/chronotope/chrono/releases)
- [Changelog](https://github.com/chronotope/chrono/blob/main/CHANGELOG.md)
- [Commits](chronotope/chrono@v0.4.37...v0.4.38)

---
updated-dependencies:
- dependency-name: chrono
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: deps Anything related to Vector's dependencies no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant