Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump windows-service from 0.6.0 to 0.7.0 #20317

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 17, 2024

Bumps windows-service from 0.6.0 to 0.7.0.

Changelog

Sourced from windows-service's changelog.

[0.7.0] - 2024-04-12

Added

  • Breaking: Add support for user-defined control codes in services. (See: Service::notify and notify_service.rs example). This is breaking since the ServiceControl enum was exhaustive in version 0.6.0.
  • Breaking: Add support for LidSwitchStateChange in PowerBroadcastSetting. This is breaking since PowerBroadcastSetting was an exhaustive enum in version 0.6.0.
  • Breaking: Add support for SERVICE_SYSTEM_START and SERVICE_BOOT_START in service start type. This is breaking since the ServiceStartType enum is exhaustive.
  • Add function for obtaining service SID infos. (See: Service::get_config_service_sid_info).

Changed

  • Breaking: Make a bunch of enums #[non_exhaustive]: Error, PowerBroadcastSetting, PowerEventParam and ServiceControl.
  • Breaking: Upgrade windows-sys dependency to 0.52
Commits
  • 7229110 Merge branch 'prepare-0.7.0'
  • 507f9cc Bump version to 0.7.0
  • e3e605a Fix wrong changelog entry about SessionChangeReason
  • c4a368d Elaborate on changelog entries that are breaking
  • 4996b6b Add note about upgrading windows-sys to changelog
  • 4c31d1e Add changelog entry about SystemStart and BootStart
  • a87e63c Merge branch 'mark-enums-non_exhaustive'
  • f215e4a Add to changelog
  • 687499e Mark PowerEventParam non_exhaustive
  • da5d253 Make main Error enum non_exhaustive
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added domain: deps Anything related to Vector's dependencies no-changelog Changes in this PR do not need user-facing explanations in the release changelog labels Apr 17, 2024
Bumps [windows-service](https://github.com/mullvad/windows-service-rs) from 0.6.0 to 0.7.0.
- [Release notes](https://github.com/mullvad/windows-service-rs/releases)
- [Changelog](https://github.com/mullvad/windows-service-rs/blob/main/CHANGELOG.md)
- [Commits](mullvad/windows-service-rs@v0.6.0...v0.7.0)

---
updated-dependencies:
- dependency-name: windows-service
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/windows-service-0.7.0 branch from d19e246 to 402229d Compare April 18, 2024 17:30
@jszwedko jszwedko added this pull request to the merge queue Apr 19, 2024
Copy link

Regression Detector Results

Run ID: 55bb1e70-5f5c-4cdf-aae6-ae0f48edbbf5
Baseline: b4b96aa
Comparison: 431a3c0
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
splunk_hec_route_s3 ingress throughput +1.96 [+1.50, +2.43]
syslog_humio_logs ingress throughput +1.81 [+1.67, +1.94]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +1.67 [+1.56, +1.79]
socket_to_socket_blackhole ingress throughput +1.33 [+1.25, +1.41]
syslog_log2metric_splunk_hec_metrics ingress throughput +0.90 [+0.74, +1.06]
otlp_http_to_blackhole ingress throughput +0.83 [+0.70, +0.96]
datadog_agent_remap_blackhole ingress throughput +0.75 [+0.65, +0.85]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.64 [+0.56, +0.73]
datadog_agent_remap_datadog_logs ingress throughput +0.64 [+0.53, +0.76]
file_to_blackhole egress throughput +0.53 [-2.04, +3.10]
syslog_log2metric_humio_metrics ingress throughput +0.45 [+0.32, +0.57]
http_elasticsearch ingress throughput +0.43 [+0.36, +0.51]
http_to_s3 ingress throughput +0.42 [+0.14, +0.71]
syslog_splunk_hec_logs ingress throughput +0.41 [+0.29, +0.53]
http_to_http_noack ingress throughput +0.13 [+0.03, +0.22]
datadog_agent_remap_blackhole_acks ingress throughput +0.11 [+0.01, +0.21]
http_to_http_json ingress throughput +0.04 [-0.04, +0.11]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.14, +0.14]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.14, +0.14]
enterprise_http_to_http ingress throughput -0.03 [-0.09, +0.03]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.04 [-0.15, +0.07]
fluent_elasticsearch ingress throughput -0.07 [-0.55, +0.41]
http_to_http_acks ingress throughput -0.25 [-1.61, +1.11]
otlp_grpc_to_blackhole ingress throughput -0.96 [-1.04, -0.88]
http_text_to_http_json ingress throughput -1.09 [-1.21, -0.96]
syslog_loki ingress throughput -1.39 [-1.46, -1.32]
syslog_regex_logs2metric_ddmetrics ingress throughput -2.27 [-2.40, -2.14]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into master with commit 431a3c0 Apr 19, 2024
50 checks passed
@jszwedko jszwedko deleted the dependabot/cargo/windows-service-0.7.0 branch April 19, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: deps Anything related to Vector's dependencies no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant