fix(socket sink): Allow socket sink to accept metrics.

[nichtverstehen]

Closes #20756

[bits-bot]

All committers have signed the CLA.

[jszwedko]

Great, thank you @nichtverstehen !

One request, could we add a changelog entry describing the change for Vector users? See https://github.com/vectordotdev/vector/blob/master/changelog.d/README.md for details.

[nichtverstehen]

@jszwedko Thanks for the quick review. Added a changelog entry.

[jszwedko]

One note about the changelog, otherwise 👍

[nichtverstehen]

Made changes required by a check. @jszwedko could you please reapprove?

[github-actions]

Regression Detector Results

Run ID: cadc165c-15dd-4f13-9e2e-f9121f72d046 Metrics dashboard

Baseline: 12b684e
Comparison: 9994176

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	links
✅	file_to_blackhole	egress throughput	+14.63	[+7.41, +21.86]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
✅	file_to_blackhole	egress throughput	+14.63	[+7.41, +21.86]
➖	syslog_log2metric_humio_metrics	ingress throughput	+4.66	[+4.54, +4.79]
➖	datadog_agent_remap_blackhole_acks	ingress throughput	+1.81	[+1.70, +1.92]
➖	datadog_agent_remap_datadog_logs_acks	ingress throughput	+1.37	[+1.19, +1.55]
➖	datadog_agent_remap_blackhole	ingress throughput	+1.28	[+1.15, +1.41]
➖	splunk_hec_route_s3	ingress throughput	+1.25	[+0.87, +1.62]
➖	http_text_to_http_json	ingress throughput	+1.20	[+1.08, +1.31]
➖	syslog_regex_logs2metric_ddmetrics	ingress throughput	+0.54	[+0.37, +0.71]
➖	datadog_agent_remap_datadog_logs	ingress throughput	+0.53	[+0.35, +0.71]
➖	syslog_log2metric_tag_cardinality_limit_blackhole	ingress throughput	+0.41	[+0.30, +0.53]
➖	syslog_log2metric_splunk_hec_metrics	ingress throughput	+0.40	[+0.22, +0.57]
➖	syslog_splunk_hec_logs	ingress throughput	+0.22	[+0.09, +0.34]
➖	fluent_elasticsearch	ingress throughput	+0.14	[-0.36, +0.63]
➖	splunk_hec_to_splunk_hec_logs_noack	ingress throughput	+0.03	[-0.07, +0.13]
➖	http_to_http_noack	ingress throughput	-0.00	[-0.02, +0.02]
➖	http_to_http_json	ingress throughput	-0.00	[-0.03, +0.03]
➖	splunk_hec_to_splunk_hec_logs_acks	ingress throughput	-0.00	[-0.11, +0.11]
➖	splunk_hec_indexer_ack_blackhole	ingress throughput	-0.01	[-0.10, +0.07]
➖	http_to_s3	ingress throughput	-0.03	[-0.30, +0.24]
➖	otlp_http_to_blackhole	ingress throughput	-0.24	[-0.37, -0.10]
➖	otlp_grpc_to_blackhole	ingress throughput	-0.48	[-0.59, -0.36]
➖	syslog_humio_logs	ingress throughput	-1.03	[-1.14, -0.92]
➖	http_elasticsearch	ingress throughput	-1.18	[-1.38, -0.98]
➖	http_to_http_acks	ingress throughput	-1.29	[-2.60, +0.01]
➖	syslog_loki	ingress throughput	-1.46	[-1.53, -1.38]
➖	socket_to_socket_blackhole	ingress throughput	-4.12	[-4.18, -4.06]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[github-actions]

Regression Detector Results

Run ID: 306fce23-d18e-4246-b204-aac637d9f5e1 Metrics dashboard

Baseline: 886f4e1
Comparison: e2f30d0

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

perf	experiment	goal	Δ mean %	Δ mean % CI	links
❌	syslog_humio_logs	ingress throughput	-5.16	[-5.31, -5.01]

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	file_to_blackhole	egress throughput	-4.25	[-11.27, +2.77]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	syslog_regex_logs2metric_ddmetrics	ingress throughput	+4.73	[+4.54, +4.92]
➖	syslog_log2metric_humio_metrics	ingress throughput	+3.11	[+2.97, +3.25]
➖	syslog_log2metric_tag_cardinality_limit_blackhole	ingress throughput	+1.18	[+1.10, +1.26]
➖	socket_to_socket_blackhole	ingress throughput	+1.06	[+0.98, +1.14]
➖	otlp_grpc_to_blackhole	ingress throughput	+1.04	[+0.93, +1.15]
➖	fluent_elasticsearch	ingress throughput	+1.03	[+0.54, +1.52]
➖	datadog_agent_remap_datadog_logs_acks	ingress throughput	+0.98	[+0.79, +1.16]
➖	otlp_http_to_blackhole	ingress throughput	+0.91	[+0.79, +1.03]
➖	syslog_splunk_hec_logs	ingress throughput	+0.81	[+0.69, +0.93]
➖	http_elasticsearch	ingress throughput	+0.67	[+0.52, +0.82]
➖	http_to_http_acks	ingress throughput	+0.36	[-0.96, +1.69]
➖	http_text_to_http_json	ingress throughput	+0.32	[+0.19, +0.45]
➖	datadog_agent_remap_blackhole	ingress throughput	+0.22	[+0.11, +0.33]
➖	http_to_http_noack	ingress throughput	+0.15	[+0.07, +0.23]
➖	http_to_http_json	ingress throughput	+0.05	[+0.01, +0.10]
➖	syslog_loki	ingress throughput	+0.05	[-0.04, +0.13]
➖	splunk_hec_indexer_ack_blackhole	ingress throughput	+0.00	[-0.08, +0.08]
➖	splunk_hec_to_splunk_hec_logs_noack	ingress throughput	-0.00	[-0.10, +0.09]
➖	splunk_hec_to_splunk_hec_logs_acks	ingress throughput	-0.01	[-0.15, +0.13]
➖	http_to_s3	ingress throughput	-0.20	[-0.47, +0.06]
➖	splunk_hec_route_s3	ingress throughput	-0.25	[-0.57, +0.06]
➖	syslog_log2metric_splunk_hec_metrics	ingress throughput	-0.38	[-0.50, -0.26]
➖	datadog_agent_remap_blackhole_acks	ingress throughput	-1.22	[-1.35, -1.09]
➖	datadog_agent_remap_datadog_logs	ingress throughput	-1.43	[-1.62, -1.24]
➖	file_to_blackhole	egress throughput	-4.25	[-11.27, +2.77]
❌	syslog_humio_logs	ingress throughput	-5.16	[-5.31, -5.01]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[github-actions]

Regression Detector Results

Run ID: 2723f2d6-2c91-4ae6-a73a-097a6dc08f8c Metrics dashboard

Baseline: 4f4b4ea
Comparison: f890b6a

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	links
✅	file_to_blackhole	egress throughput	+21.09	[+13.42, +28.76]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
✅	file_to_blackhole	egress throughput	+21.09	[+13.42, +28.76]
➖	socket_to_socket_blackhole	ingress throughput	+3.53	[+3.47, +3.60]
➖	syslog_loki	ingress throughput	+2.98	[+2.91, +3.05]
➖	syslog_humio_logs	ingress throughput	+2.22	[+2.13, +2.30]
➖	http_text_to_http_json	ingress throughput	+1.62	[+1.49, +1.75]
➖	http_elasticsearch	ingress throughput	+1.34	[+1.18, +1.49]
➖	http_to_http_acks	ingress throughput	+1.17	[-0.15, +2.49]
➖	splunk_hec_route_s3	ingress throughput	+1.03	[+0.72, +1.35]
➖	syslog_splunk_hec_logs	ingress throughput	+0.47	[+0.38, +0.55]
➖	http_to_s3	ingress throughput	+0.31	[+0.04, +0.58]
➖	syslog_log2metric_splunk_hec_metrics	ingress throughput	+0.21	[+0.08, +0.33]
➖	syslog_log2metric_tag_cardinality_limit_blackhole	ingress throughput	+0.18	[+0.09, +0.27]
➖	http_to_http_json	ingress throughput	+0.09	[+0.03, +0.16]
➖	http_to_http_noack	ingress throughput	+0.09	[+0.03, +0.16]
➖	otlp_http_to_blackhole	ingress throughput	+0.08	[-0.05, +0.21]
➖	splunk_hec_to_splunk_hec_logs_noack	ingress throughput	+0.01	[-0.08, +0.11]
➖	splunk_hec_indexer_ack_blackhole	ingress throughput	+0.01	[-0.07, +0.09]
➖	splunk_hec_to_splunk_hec_logs_acks	ingress throughput	+0.00	[-0.12, +0.13]
➖	datadog_agent_remap_datadog_logs	ingress throughput	-0.19	[-0.41, +0.03]
➖	datadog_agent_remap_blackhole_acks	ingress throughput	-0.24	[-0.37, -0.12]
➖	otlp_grpc_to_blackhole	ingress throughput	-0.30	[-0.41, -0.18]
➖	datadog_agent_remap_datadog_logs_acks	ingress throughput	-1.22	[-1.45, -0.99]
➖	syslog_regex_logs2metric_ddmetrics	ingress throughput	-1.28	[-1.43, -1.14]
➖	fluent_elasticsearch	ingress throughput	-1.52	[-2.01, -1.03]
➖	datadog_agent_remap_blackhole	ingress throughput	-2.50	[-2.61, -2.40]
➖	syslog_log2metric_humio_metrics	ingress throughput	-2.66	[-2.79, -2.52]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[nichtverstehen]

Sigh. Made imports conditional.

[nichtverstehen]

Added a platform guard for the symbol that became unused after guarding another unused symbol.

Is there a way to run the windows linter ahead of time?

[jszwedko]

Added a platform guard for the symbol that became unused after guarding another unused symbol.

Is there a way to run the windows linter ahead of time?

Thanks! It doesn't run on PRs until the merge queue because it is more expensive than the other checks and doesn't fail often in isolation (i.e. if it fails the Linux one, which does run on PRs, would fail too).

[github-actions]

Regression Detector Results

Run ID: a2ea1254-1fd8-4f7c-822b-6bec8b198d67 Metrics dashboard

Baseline: 6e803a3
Comparison: 6772029

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

perf	experiment	goal	Δ mean %	Δ mean % CI	links
✅	syslog_humio_logs	ingress throughput	+5.11	[+4.95, +5.26]

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	links
✅	file_to_blackhole	egress throughput	+7.83	[+0.92, +14.73]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
✅	file_to_blackhole	egress throughput	+7.83	[+0.92, +14.73]
✅	syslog_humio_logs	ingress throughput	+5.11	[+4.95, +5.26]
➖	http_text_to_http_json	ingress throughput	+4.89	[+4.76, +5.02]
➖	syslog_splunk_hec_logs	ingress throughput	+2.26	[+2.14, +2.37]
➖	splunk_hec_route_s3	ingress throughput	+1.31	[+0.99, +1.63]
➖	http_elasticsearch	ingress throughput	+0.85	[+0.68, +1.02]
➖	otlp_http_to_blackhole	ingress throughput	+0.76	[+0.62, +0.89]
➖	socket_to_socket_blackhole	ingress throughput	+0.54	[+0.47, +0.61]
➖	syslog_log2metric_humio_metrics	ingress throughput	+0.31	[+0.16, +0.46]
➖	http_to_http_acks	ingress throughput	+0.28	[-1.04, +1.60]
➖	http_to_http_noack	ingress throughput	+0.19	[+0.10, +0.28]
➖	http_to_http_json	ingress throughput	+0.11	[+0.05, +0.18]
➖	splunk_hec_to_splunk_hec_logs_acks	ingress throughput	-0.00	[-0.11, +0.11]
➖	splunk_hec_to_splunk_hec_logs_noack	ingress throughput	-0.00	[-0.10, +0.09]
➖	splunk_hec_indexer_ack_blackhole	ingress throughput	-0.02	[-0.11, +0.07]
➖	datadog_agent_remap_datadog_logs_acks	ingress throughput	-0.03	[-0.17, +0.12]
➖	otlp_grpc_to_blackhole	ingress throughput	-0.31	[-0.42, -0.19]
➖	datadog_agent_remap_datadog_logs	ingress throughput	-0.39	[-0.62, -0.17]
➖	syslog_log2metric_tag_cardinality_limit_blackhole	ingress throughput	-0.98	[-1.08, -0.88]
➖	datadog_agent_remap_blackhole	ingress throughput	-1.07	[-1.20, -0.95]
➖	http_to_s3	ingress throughput	-1.11	[-1.38, -0.84]
➖	syslog_loki	ingress throughput	-1.69	[-1.77, -1.62]
➖	datadog_agent_remap_blackhole_acks	ingress throughput	-1.97	[-2.08, -1.87]
➖	fluent_elasticsearch	ingress throughput	-2.19	[-2.69, -1.69]
➖	syslog_regex_logs2metric_ddmetrics	ingress throughput	-2.52	[-2.67, -2.38]
➖	syslog_log2metric_splunk_hec_metrics	ingress throughput	-3.08	[-3.21, -2.96]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[github-actions]

Regression Detector Results

Run ID: 12f7ef1b-7269-4ec9-b5bb-4112bd3e56c0 Metrics dashboard

Baseline: 6e803a3
Comparison: 9121a7f

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

perf	experiment	goal	Δ mean %	Δ mean % CI	links
✅	syslog_regex_logs2metric_ddmetrics	ingress throughput	+5.52	[+5.34, +5.70]

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	links
✅	file_to_blackhole	egress throughput	+23.12	[+15.20, +31.04]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
✅	file_to_blackhole	egress throughput	+23.12	[+15.20, +31.04]
✅	syslog_regex_logs2metric_ddmetrics	ingress throughput	+5.52	[+5.34, +5.70]
➖	syslog_log2metric_splunk_hec_metrics	ingress throughput	+3.84	[+3.71, +3.96]
➖	http_to_http_acks	ingress throughput	+2.12	[+0.79, +3.44]
➖	otlp_http_to_blackhole	ingress throughput	+1.37	[+1.24, +1.50]
➖	http_text_to_http_json	ingress throughput	+1.31	[+1.18, +1.43]
➖	datadog_agent_remap_datadog_logs	ingress throughput	+0.88	[+0.67, +1.09]
➖	otlp_grpc_to_blackhole	ingress throughput	+0.60	[+0.48, +0.72]
➖	syslog_log2metric_humio_metrics	ingress throughput	+0.37	[+0.26, +0.48]
➖	syslog_log2metric_tag_cardinality_limit_blackhole	ingress throughput	+0.21	[+0.11, +0.31]
➖	http_elasticsearch	ingress throughput	+0.13	[-0.03, +0.30]
➖	http_to_http_json	ingress throughput	+0.04	[-0.00, +0.09]
➖	splunk_hec_to_splunk_hec_logs_noack	ingress throughput	+0.02	[-0.08, +0.12]
➖	splunk_hec_indexer_ack_blackhole	ingress throughput	+0.01	[-0.07, +0.09]
➖	splunk_hec_to_splunk_hec_logs_acks	ingress throughput	+0.01	[-0.09, +0.11]
➖	http_to_http_noack	ingress throughput	-0.00	[-0.02, +0.02]
➖	syslog_splunk_hec_logs	ingress throughput	-0.19	[-0.27, -0.11]
➖	socket_to_socket_blackhole	ingress throughput	-0.25	[-0.28, -0.21]
➖	syslog_loki	ingress throughput	-0.28	[-0.36, -0.21]
➖	datadog_agent_remap_blackhole_acks	ingress throughput	-0.43	[-0.55, -0.31]
➖	splunk_hec_route_s3	ingress throughput	-0.72	[-1.04, -0.40]
➖	http_to_s3	ingress throughput	-0.94	[-1.22, -0.66]
➖	fluent_elasticsearch	ingress throughput	-1.10	[-1.59, -0.60]
➖	datadog_agent_remap_datadog_logs_acks	ingress throughput	-1.38	[-1.56, -1.21]
➖	datadog_agent_remap_blackhole	ingress throughput	-1.60	[-1.71, -1.49]
➖	syslog_humio_logs	ingress throughput	-4.27	[-4.38, -4.16]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".