chore(ci): add codec test data dir to regression workflow ignore filter #21185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neuronull
added
domain: ci
github-actions
bot
removed
the
domain: ci
jszwedko
approved these changes
Aug 29, 2024
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.44s Total Time |
neuronull
deleted the
neuronull/ci_ignore_codec_test_data_regression_workflow
branch
AndrooTheChen
pushed a commit
to discord/vector
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently discovered in #21074 , that PRs which regenerate the fixture files for codec tests (which results in a 💩 ton of file changes) , breaks a check in this workflow due to
hit on the
filterjob.We should ignore that test data dir anyway and hopefully it addresses that issue.