Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(releasing): Prepare v0.41.1 release #21264

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Conversation

jszwedko
Copy link
Member

Checklist: #21263

)

* remove error log

* make source_event_id optional + add error log when failing to parse empty field

* update tag number

* undo proto changes, remove error log, and make source_event_id optional in EventMetadata

* cargo fmt

* fix test + re-add error logic for certain cases
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Sep 10, 2024
@jszwedko jszwedko requested review from a team as code owners September 10, 2024 21:36
Copy link
Member Author

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ci-run-all

@github-actions github-actions bot added domain: releasing Anything related to releasing Vector domain: external docs Anything related to Vector's external, public documentation domain: core Anything related to core crates i.e. vector-core, core-common, etc labels Sep 10, 2024
#21255)

* chore(releasing): Add known issue around `source_event_id` for v0.41.0

Signed-off-by: Jesse Szwedko <[email protected]>

* Add note about fix version

Signed-off-by: Jesse Szwedko <[email protected]>

---------

Signed-off-by: Jesse Szwedko <[email protected]>
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: jszwedko/prepare-v0.41.1
Commit report: 0598340
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.5s Total Time

Copy link

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for docs

Copy link

Regression Detector Results

Run ID: bb1851cc-afc6-4bbf-9bb0-83d8af9b52a6 Metrics dashboard

Baseline: 00ef42b
Comparison: 9e7aaf4

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI links
file_to_blackhole egress throughput -3.28 [-10.43, +3.87]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
http_to_http_acks ingress throughput +3.89 [+2.62, +5.15]
syslog_log2metric_humio_metrics ingress throughput +2.37 [+2.23, +2.51]
datadog_agent_remap_blackhole ingress throughput +1.37 [+1.26, +1.48]
socket_to_socket_blackhole ingress throughput +0.86 [+0.78, +0.93]
syslog_loki ingress throughput +0.79 [+0.68, +0.89]
http_text_to_http_json ingress throughput +0.56 [+0.42, +0.70]
datadog_agent_remap_datadog_logs ingress throughput +0.55 [+0.32, +0.79]
http_elasticsearch ingress throughput +0.44 [+0.27, +0.61]
http_to_s3 ingress throughput +0.38 [+0.11, +0.66]
syslog_log2metric_splunk_hec_metrics ingress throughput +0.36 [+0.28, +0.44]
http_to_http_noack ingress throughput +0.23 [+0.13, +0.32]
syslog_humio_logs ingress throughput +0.17 [+0.04, +0.30]
http_to_http_json ingress throughput +0.08 [+0.02, +0.13]
splunk_hec_to_splunk_hec_logs_noack ingress throughput +0.01 [-0.08, +0.11]
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.12, +0.11]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.09, +0.09]
fluent_elasticsearch ingress throughput -0.20 [-0.69, +0.28]
datadog_agent_remap_blackhole_acks ingress throughput -0.28 [-0.43, -0.13]
syslog_splunk_hec_logs ingress throughput -0.53 [-0.61, -0.45]
otlp_grpc_to_blackhole ingress throughput -0.71 [-0.82, -0.60]
datadog_agent_remap_datadog_logs_acks ingress throughput -1.46 [-1.65, -1.27]
otlp_http_to_blackhole ingress throughput -1.76 [-1.88, -1.64]
syslog_regex_logs2metric_ddmetrics ingress throughput -1.84 [-1.99, -1.68]
splunk_hec_route_s3 ingress throughput -2.34 [-2.64, -2.03]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -2.62 [-2.72, -2.52]
file_to_blackhole egress throughput -3.28 [-10.43, +3.87]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Copy link
Contributor

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jszwedko

@jszwedko jszwedko merged commit 745babd into v0.41 Sep 11, 2024
81 checks passed
@jszwedko jszwedko deleted the jszwedko/prepare-v0.41.1 branch September 11, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: core Anything related to core crates i.e. vector-core, core-common, etc domain: external docs Anything related to Vector's external, public documentation domain: releasing Anything related to releasing Vector no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants