Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(new_relic sink): Fix handling of dotted attribute names #21305

Merged
merged 5 commits into from
Sep 18, 2024

Commits on Sep 13, 2024

  1. Break up the test functions

    bruceg committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    816b674 View commit details
    Browse the repository at this point in the history
  2. Rework test comparison

    bruceg committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    eec498f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e1046f5 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Fix encoding of dotted field names through allowing nesting

    This converts log event into a logs API model simply by transmuting the type
    wrapper and dropping all arrays, which are not supported by the API. We could
    flatten out the keys, as this is what New Relic does internally, and we used to
    do that, but the flattening iterator accessed through
    `LogEvent::convert_to_fields` adds quotes to dotted fields names, which produces
    broken attributes in New Relic, and nesting objects is actually a (slightly)
    more efficient representation of the key names.
    bruceg committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    cd921b9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ab41ee3 View commit details
    Browse the repository at this point in the history