Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(enriching): add
memory
enrichment table #21348feat(enriching): add
memory
enrichment table #21348Changes from 32 commits
d919678
2a3b3dd
759ec92
18ef6f0
45995ec
74b1825
8c46422
ec6efad
a56b51c
4984db7
65a05f3
f217abf
724e6f6
8123227
112b9fc
e17880a
5c6f7ac
5032181
93e90dd
b3c4488
91d1121
dfff8f9
cb4dacb
31c75fc
2d1ed34
ce0b357
8524b6a
7b4712c
6aa6a82
5b94be3
3f86c32
4bd0cff
ed659e9
97f6a5b
3531ee0
38bfdde
0da8298
372b3f6
cb462f4
38e8388
7f3a8f6
fabfe7c
b57c359
97d6214
2986613
bb8d13f
e1e8dc6
e5693b9
d4c7f9f
ba2d548
0e445d3
012a07b
9f86f95
156e4d7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a reasonable way to do it the way things are currently designed, but it definitely shows the limitations of how we do things with
SinkOuter
, etc.If I were to re-approach it, I think I would limit
SinkOuter
to config deserialization (and drop the generic to justString
), and map to some more granular things to build the topology (e.g. something for inputs, something for healthchecks, etc). That way we could try to unify where we handle "things that have inputs", etc.You certainly don't need to do any of that, but it could be something to explore if you'd like to make this feel cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, not sure how often components such as this one would come up, but it definitely makes sense for components such as this one, that don't really fit just one type.
I can think about it, but I think that would be a too big undertaking for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Let's add a comment summarizing the limitation's Luke mentioned above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, it would be great if everything was just a node in a graph. Chaining sinks would unlock a lot of heavily requested features. Great topic.