Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http sink): Adds an extra clone before shipping off http body #22002

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(http sink): Adds an extra clone before shipping off http body #22002

wants to merge 1 commit into from

Conversation

scottopell
Copy link
Contributor

Summary

This introduces a slight performance regression. You probably shouldn't merge it.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@scottopell scottopell added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Dec 10, 2024
@bits-bot
Copy link

bits-bot commented Dec 10, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Dec 10, 2024
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: sopell/cloner
Commit report: 4abcad2
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.46s Total Time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do not merge domain: sinks Anything related to the Vector's sinks no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottopell @bits-bot @pront