Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(#16369): Add chronicle udm events sink #22155

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

ChocPanda
Copy link
Contributor

@ChocPanda ChocPanda commented Jan 10, 2025

Summary

Add a new Google Chronicle log sink for UDM events. The log sink acts as a client for the Google Chronicle udmevents ingestion API. Forwarding udm data in a Json format. it is assumed that the events will already be compliant with the Google Chronicles UDM format

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Added new integration tests
Tested manually against a live Google Chronicle deployment

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

#16369

@ChocPanda ChocPanda requested review from a team as code owners January 10, 2025 12:21
@github-actions github-actions bot added domain: sinks Anything related to the Vector's sinks domain: ci Anything related to Vector's CI environment labels Jan 10, 2025
@brett0000FF brett0000FF self-assigned this Jan 10, 2025
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for docs/tutorials/sinks/1_basic_sink.md.

@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Jan 13, 2025
@pront pront changed the title WIP: feature(#16369): Add chronicle udm events sink feature(#16369): Add chronicle udm events sink Jan 13, 2025
@pront pront self-assigned this Jan 13, 2025
@ChocPanda
Copy link
Contributor Author

Hey @pront, I just raised the PR because I like the github diff, I'm still testing the change and the integration tests on this branch don't work yet.
If you have sometime to work with me on this your expertise would be greatly appreciated as I'm teaching myself rust while working on this but this PR is still very much a draft

@ChocPanda ChocPanda marked this pull request as draft January 13, 2025 18:39
@pront
Copy link
Member

pront commented Jan 13, 2025

Hey @pront, I just raised the PR because I like the github diff, I'm still testing the change and the integration tests on this branch don't work yet.

Sounds good @ChocPanda 👍

If you have sometime to work with me on this your expertise would be greatly appreciated as I'm teaching myself rust while working on this but this PR is still very much a draft

Feel free to ping me, when you want a code review!

@ChocPanda ChocPanda force-pushed the chronicle-udmevents branch 3 times, most recently from c49269e to d6315a5 Compare January 15, 2025 16:36
@ChocPanda ChocPanda force-pushed the chronicle-udmevents branch from d6315a5 to 619d8cc Compare January 15, 2025 18:37
@github-actions github-actions bot added the domain: vdev Anything related to the vdev tooling label Jan 15, 2025
@ChocPanda ChocPanda force-pushed the chronicle-udmevents branch from e10d0e9 to 9173ec1 Compare January 15, 2025 20:56
@github-actions github-actions bot removed the domain: vdev Anything related to the vdev tooling label Jan 15, 2025
@ChocPanda ChocPanda force-pushed the chronicle-udmevents branch from 77326b2 to 6ce1c16 Compare January 16, 2025 19:56
@ChocPanda ChocPanda force-pushed the chronicle-udmevents branch 3 times, most recently from b1582c3 to 6bd6ccd Compare January 17, 2025 10:51
@ChocPanda ChocPanda force-pushed the chronicle-udmevents branch from 6bd6ccd to 2b72a61 Compare January 17, 2025 10:53
@ChocPanda ChocPanda marked this pull request as ready for review January 17, 2025 10:59
@ChocPanda ChocPanda force-pushed the chronicle-udmevents branch from 5669ad6 to 56efb46 Compare January 17, 2025 11:01
@ChocPanda
Copy link
Contributor Author

Hey @pront, I've tested this manually and have the integration tests working.
There's quite a bit of refactoring in here and I'm not sure the acknowledgements work properly so all feedback welcome.

@ChocPanda
Copy link
Contributor Author

This PR includes the changes in #22033

@pront
Copy link
Member

pront commented Jan 17, 2025

This PR includes the changes in #22033

Let's try to merge this #22033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: ci Anything related to Vector's CI environment domain: external docs Anything related to Vector's external, public documentation domain: sinks Anything related to the Vector's sinks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants