Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): add notice on timestamp field renaming in the Elasticsearch sink, when use data_stream mode #22196

Conversation

up2neck
Copy link
Contributor

@up2neck up2neck commented Jan 14, 2025

Summary

Elasticsearch sink documentation doesn't highlight data_stream mode behavior on .timestamp field.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
    • make check-all is a good command to run locally. This check is
      defined here. Some of these
      checks might not be relevant to your PR. For Rust changes, at the very least you should run:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@up2neck up2neck requested review from a team as code owners January 14, 2025 11:50
@bits-bot
Copy link

bits-bot commented Jan 14, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Jan 14, 2025
@up2neck up2neck force-pushed the feature/website-elasticsearch-timestamp-notice branch 2 times, most recently from e0ece1f to 54ee28b Compare January 14, 2025 11:54
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small editorial edit.

@up2neck up2neck force-pushed the feature/website-elasticsearch-timestamp-notice branch from 54ee28b to 833b631 Compare January 14, 2025 18:22
@up2neck up2neck requested a review from a team as a code owner January 14, 2025 18:22
@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Jan 14, 2025
@up2neck up2neck force-pushed the feature/website-elasticsearch-timestamp-notice branch from 833b631 to 0e803c2 Compare January 15, 2025 07:11
@up2neck up2neck requested review from maycmlee and pront January 15, 2025 09:55
@up2neck up2neck force-pushed the feature/website-elasticsearch-timestamp-notice branch from 0e803c2 to 22de070 Compare January 15, 2025 09:56
@pront pront enabled auto-merge January 16, 2025 15:19
auto-merge was automatically disabled January 17, 2025 10:28

Head branch was pushed to by a user without write access

@up2neck up2neck force-pushed the feature/website-elasticsearch-timestamp-notice branch from 22de070 to 2dac288 Compare January 17, 2025 10:28
@up2neck
Copy link
Contributor Author

up2neck commented Jan 17, 2025

@maycmlee @pront
Synched my branch with the master.

@up2neck up2neck requested review from maycmlee and pront January 17, 2025 10:31
@pront pront enabled auto-merge January 17, 2025 16:07
auto-merge was automatically disabled January 22, 2025 07:12

Head branch was pushed to by a user without write access

@up2neck up2neck force-pushed the feature/website-elasticsearch-timestamp-notice branch from 2dac288 to fa5f140 Compare January 22, 2025 07:12
@up2neck
Copy link
Contributor Author

up2neck commented Jan 22, 2025

@pront
Seems like automatic merge doesn't work because it expects for changelog to be updated, does it?

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jan 22, 2025
@pront pront enabled auto-merge January 22, 2025 15:40
@pront
Copy link
Member

pront commented Jan 22, 2025

@pront Seems like automatic merge doesn't work because it expects for changelog to be updated, does it?

Updated labels and approved check run 🚀

auto-merge was automatically disabled January 22, 2025 17:27

Head branch was pushed to by a user without write access

@up2neck up2neck force-pushed the feature/website-elasticsearch-timestamp-notice branch from fa5f140 to 4772bc9 Compare January 22, 2025 17:27
@up2neck
Copy link
Contributor Author

up2neck commented Jan 22, 2025

@pront
Unfortunately there was trailing whitespace :) It requires your approval again

@pront pront enabled auto-merge January 22, 2025 17:51
@pront pront added this pull request to the merge queue Jan 22, 2025
Merged via the queue into vectordotdev:master with commit 0df7c48 Jan 22, 2025
74 checks passed
@up2neck up2neck deleted the feature/website-elasticsearch-timestamp-notice branch January 22, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation domain: sinks Anything related to the Vector's sinks no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants