enhancement(gcp_chronicle sink): Add default fallback logic if log_type template cannot be resolved fo… #22323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r Google Chronicle sink
github-actions
bot
added
the
domain: sinks
ArunPiduguDD
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
changelog.d/changelog.d/add_default_fallback_index_google_chronicle_sink.enhancement.md
Fixed
Show fixed
Hide fixed
ArunPiduguDD
force-pushed
the
add-google-chronicle-unresolved-log-type-template-default-fallback
branch
from
40d8e47 to
25f0f17
Compare
|
Hey @ArunPiduguDD, do you need a review on this? It's marked as a draft but I am getting notifications because you tagged me as a reviewer. Happy to review when it's ready. |
@pront Just marked it as ready for review |
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.49s Total Time |
github-actions
bot
added
the
domain: external docs
michaelcretzman
approved these changes
Jan 30, 2025
pront
reviewed
Jan 30, 2025
changelog.d/add_default_fallback_index_google_chronicle_sink.enhancement.md
Outdated
Show resolved
Hide resolved
pront
approved these changes
Jan 31, 2025
ArunPiduguDD
deleted the
add-google-chronicle-unresolved-log-type-template-default-fallback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Similar to changes made for the Elasticsearch and Object Storage sinks
Currently, the Google Chronicle sink has the option to specify an log_type to attach to events. This field supports template syntax, however if the template is not able to be resolved, the default behavior is to drop the event.
Adding an optional field that specifies a default fallback log_type that can be used if there is a template rendering error.
Testing
Tested using Vector pipeline with a Google Chronicle sink