[1.20.1] Add EMI compat. #971
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MerchantPug
added a commit
to MehVahdJukaar/FarmersDelightRefabricated
that referenced
this pull request
Aug 23, 2024
|
In case there is no desire to merge this into FD, could this be a standalone addon instead? |
Absolutely! I'll make the addon. |
|
Any news on a potential addon to fix this? :D Farmers Delight is the only mod in my pack that does not show recipes in the crafting menu. |
Ive been busy lately and i want to wait on this PR's resolution before i put effort into that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #877
The main difficulty here was translating every tag, but ideally, you won't have to change the tags post 1.20.1.
Look at the 1.21 PR #972 to get a general idea of how difficult updating may be. EMI has a really good API, so I'd imagine it wouldn't be too painful, but ultimately, it's your call whether this gets in or not.