Implement distinct field option for select #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add correct path
pick distinctField value from params to avoid filter affecting
add distinct action checking
vedi
requested changes
Jan 19, 2017
lib/scope.js
Outdated
| @@ -44,6 +45,10 @@ class RestifizerScope { | |||
| return this.checkActionName(ACTIONS.SELECT, ACTIONS.SELECT_ONE, ACTIONS.COUNT); | |||
| } | |||
|
|
|||
| isSelectDistinct() { | |||
| return this.checkActionName(ACTIONS.DISTINCT); | |||
There was a problem hiding this comment.
@vedi, I just wanted to separate select and distinct, because in one of our projects the same collection post-processing lead to crashes.
There was a problem hiding this comment.
It's a select by the meaning, and you named the method isSelectDistinct approving this. If you have an issue in your project after this change, it's better to update the code in your project.
Just in case, I mean to add DISTINCT checking to isSelect, and keep this method as well.
|
@vedi, I have a better idea, will close this one and create additional PR. |
# Conflicts: # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.