Skip to content

Commit

Permalink
Travis CI: check that dump is idempotent
Browse files Browse the repository at this point in the history
Run git-diff after dumping the database to make sure that there are no
changes to the csv files.

We often get PRs from people who edit stuff by hand and don't know to do
a load/dump of the database afterwards. Usually this means they were
adding game data by hand, which we want to discourage, but even if it's
done for valid reasons it's good to canonicalize the csv files as soon
as possible to avoid interfering with future commits.
  • Loading branch information
magical committed Mar 5, 2020
1 parent 77e3d9d commit e5c18c4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ before_script: pokedex setup -v
script:
- py.test
- pokedex dump
- git --no-pager diff --exit-code pokedex/data/csv/

0 comments on commit e5c18c4

Please sign in to comment.