fix(typing): Exclude core.FacetMapping in favor of api.FacetMapping

Now `mypy` can understand the symbol, it started complaining
vega · Sep 1, 2024 · e7fceb6 · e7fceb6
1 parent dbdc5d2
commit e7fceb6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/altair/vegalite/v5/schema/core.py b/altair/vegalite/v5/schema/core.py
@@ -158,7 +158,6 @@
     "ExtentTransform",
     "FacetEncodingFieldDef",
     "FacetFieldDef",
-    "FacetMapping",
     "FacetSpec",
     "FacetedEncoding",
     "FacetedUnitSpec",

diff --git a/tools/generate_schema_wrapper.py b/tools/generate_schema_wrapper.py
@@ -537,7 +537,7 @@ def generate_vegalite_schema_wrapper(schema_file: Path) -> str:
     # of exported classes which are also defined in the channels or api modules which takes
     # precedent in the generated __init__.py files one and two levels up.
     # Importing these classes from multiple modules confuses type checkers.
-    EXCLUDE = {"Color", "Text", "LookupData", "Dict"}
+    EXCLUDE = {"Color", "Text", "LookupData", "Dict", "FacetMapping"}
     it = (c for c in definitions.keys() - EXCLUDE if not c.startswith("_"))
     all_ = [*sorted(it), "Root", "VegaLiteSchema", "SchemaBase", "load_schema"]