Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iris to penguins #2231

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Iris to penguins #2231

wants to merge 3 commits into from

Conversation

baldwint
Copy link

@baldwint baldwint commented Jul 9, 2020

Maybe someone is already working on this, but to help with #2213 I found it fun to rewrite three of the (currently broken) compound chart documentation sections using the new penguins dataset instead of iris.

I used the mapping

{
    "sepalLength": "Beak Length (mm)",
    "sepalWidth": "Beak Depth (mm)",
    "petalLength": "Flipper Length (mm)",
    "petalWidth": "Body Mass (g)",
    "species": "Species",
}

since this seemed more or less faithful to the patterns in iris. I also chose to un-anchor the scales from zero since the penguin means are not very close to zero.

visualization

While working on this, I found it useful to make a modified version of vega_datasets that retains some of the older datasets so that the docs can build without failing on examples that haven't been updated yet.

@jakevdp
Copy link
Collaborator

jakevdp commented Jul 9, 2020

Thanks! This will have to wait for a vega-datasets release that includes the penguins data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants