Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed movie dataset columns in examples and docs #2241

Closed
wants to merge 1 commit into from

Conversation

ANich
Copy link

@ANich ANich commented Jul 17, 2020

Hey, awesome library!

I updated a few of the broken examples and docs mentioned here #2213 (comment) (that use the movie dataset).

I wasn't able to build the docs locally so I looked them over in a jupyter notebook using altair=4.1.0 and vega_datasets=0.8.0 and they looked fine.

I started looking at altair/examples/multiple_interactions.py as well but I ran into this upstream issue vega/vega-lite#4870 so I left it alone

@ANich
Copy link
Author

ANich commented Jul 17, 2020

If someone else could check with built docs that'd be great! Here's my problem:

After running pip install -r requirements in doc/ I got the following error:
Could not import extension altair.sphinxext.schematable (exception: No module named 'recommonmark')

So I ran pip install recommonmark, now make html gives me the following error:
Handler <function main at 0x7fa1f33dfae8> for event 'builder-inited' threw an exception

@ANich
Copy link
Author

ANich commented Oct 3, 2020

I was able to build the docs, I just had to follow some instructions in CONTRIBUTING and RELEASING. I opened #2306 to make this a little easier for future contributors.

(Btw this also addresses #2291 except altair/examples/multiple_interactions.py because of the upstream issue 🙂 )

Here are some screenshots:

Capture d’écran, le 2020-10-03 à 14 07 04

Capture d’écran, le 2020-10-03 à 14 13 20

@ANich
Copy link
Author

ANich commented May 14, 2022

Not relevant anymore

@ANich ANich closed this May 14, 2022
@ANich ANich deleted the fix_movies_in_docs branch May 14, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant