Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error prioritisation and messages #3009

Merged
merged 41 commits into from
Apr 25, 2023
Merged

Improve error prioritisation and messages #3009

Show file tree
Hide file tree
Changes from 39 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
09cefca
Add comments to existing tests what the errors are in the chart speci…
binste Apr 1, 2023
dc6285e
Refactor validate_jsonschema into smaller functions
binste Apr 1, 2023
a1631a1
Add new way of prioritizing errors. Group them by path to offending e…
binste Apr 2, 2023
ca5bdc5
Merge branch 'master' into improve_error_logic
binste Apr 7, 2023
77290cf
Remove whitespaces in blank line
binste Apr 7, 2023
aca989d
Make error attribute private
binste Apr 7, 2023
3af4679
Add tests for datum and value
binste Apr 7, 2023
e538e05
Add type hints to help with refactoring
binste Apr 7, 2023
7d8c939
Refactor creation of error message as preparation for handling multip…
binste Apr 7, 2023
a45d232
First draft for showing all distinct errors
binste Apr 7, 2023
2cfb9cd
Type hint validate_jsonschema
binste Apr 8, 2023
ef10d23
Add correct error message to attribute of SchemaValidationError
binste Apr 8, 2023
12857eb
Remove unnecessary deduplication in schemavalidationerror which now a…
binste Apr 8, 2023
e6c4df9
Remove _get_all_lowest_errors_with_validator
binste Apr 8, 2023
8848bb3
Add PR to changelog. Only show one line for error message improvement…
binste Apr 8, 2023
473294e
Remove indentation in error messages which had to be removed with ins…
binste Apr 8, 2023
6f0ddfc
Use f string instead of format
binste Apr 10, 2023
879cb44
Reorder methods in calling order
binste Apr 10, 2023
1cf2e22
Refactor _get_message_for_errors
binste Apr 10, 2023
26f1a03
Improve error messages for multiple errors about the same instance
binste Apr 10, 2023
65b35b0
Move call of _get_altair_class_for_error into _get_message_for_errors
binste Apr 11, 2023
058cba3
Add docstrings
binste Apr 11, 2023
9e6fb2d
Minor refactoring
binste Apr 11, 2023
b777e4d
Format code
binste Apr 11, 2023
834849b
Merge branch 'master' into improve_error_logic
binste Apr 15, 2023
114c153
Enumerate error messages. Don't separate by line as unclear how long …
binste Apr 15, 2023
2062468
Add more test examples
binste Apr 15, 2023
f28ae9b
Harmonize chart_error_example function names
binste Apr 15, 2023
09805a3
Somehow the VL 5.6.1 schema changed slightly. Including the changes h…
binste Apr 15, 2023
994308b
Revert "Somehow the VL 5.6.1 schema changed slightly. Including the c…
binste Apr 15, 2023
ee484cb
Remove # in front of error number
binste Apr 15, 2023
2b95b38
Add 'Multiple errors were found.' as a first line if multiple errors …
binste Apr 15, 2023
62e6b1a
Indent error messages from the second line onwards if multiple errors…
binste Apr 15, 2023
166b4f4
Show a maximum of 3 errors
binste Apr 15, 2023
2f84e7f
Some white spaces were removed in a description in the VL 5.6.1 schem…
binste Apr 15, 2023
739922d
Minor improvements
binste Apr 17, 2023
fa036eb
Revert minor change
binste Apr 17, 2023
3d12923
Merge branch 'master' into improve_error_logic
mattijn Apr 21, 2023
e3a96fa
re-run generate_schema_wrapper.py
mattijn Apr 21, 2023
3262a08
Merge branch 'master' into improve_error_logic
binste Apr 25, 2023
38e8148
Capitalize bullet points
binste Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading