Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Wheat and Wages case study #3086

Merged
merged 4 commits into from
Jun 18, 2023

Conversation

thomend
Copy link
Contributor

@thomend thomend commented Jun 18, 2023

Fixed appearance of the Wheat and Wages case study (see Chart below):

image

As mentioned in #2966 by @joelostblom I oriented myself at the Vega-Lite example.

Additionally there are some minor code formatting changes introduced (in line with pep8) caused by black's autoformatting.

@binste binste self-requested a review June 18, 2023 16:02
@binste binste linked an issue Jun 18, 2023 that may be closed by this pull request
Copy link
Contributor

@binste binste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @thoemi123 for fixing the example! Much appreciated :) I only changed some minor formatting issues which already existed before this PR. I built the documentation locally and it looks good:

Thumbnail:
Screenshot 2023-06-18 at 20 25 35

Example page:
image

The hosted documentation will be updated with the next release.

@binste binste merged commit 564b472 into vega:master Jun 18, 2023
12 checks passed
@thomend
Copy link
Contributor Author

thomend commented Jun 18, 2023

Thank you @binste for the swift review!

@thomend thomend deleted the wheat-and-wages-case-study branch June 18, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wheat and Wages case study appears to be broken
2 participants