add test case for writing to html file instead of only io.StringIO() #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tests increases test coverage by checking for both inline and non inline, stringio and file io chart.save calls.
This run https://github.com/franzhaas/altair/actions/runs/7544969348/job/20539544064 shows how this new test coverage finds a problem with the codecs in release 5.2.0 on windows.
This problem has been fixed in the meantime (#3278, I should have made a test back then... but better late than never...)
@jonmmease you guided the relevant code change in... is there something i need to do to get this forward? Or is this out of scope...