-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all
dependency group
#3354
Add all
dependency group
#3354
Conversation
Thanks @jonmmease! I opened vega/altair_tiles#36. Hopefully it is possible that we can support Python 3.8 as well within |
I've just released |
This reverts commit cd78a24.
Great, thanks @binste. I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jon, one suggestion!
@@ -9,7 +9,7 @@ Altair can be installed, along with the example datasets in vega_datasets_, usin | |||
|
|||
.. code-block:: bash | |||
|
|||
pip install altair vega_datasets | |||
pip install "altair[all]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip install "altair[all]" | |
pip install altair[all] |
Since there is no usage of special characters, I think we don't need the double quotes here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The quotes are needed for zsh (because square brackets are used for pattern matching), which is the default shell on MacOS. See https://stackoverflow.com/questions/30539798/zsh-no-matches-found-requestssecurity. I think this approach should be valid across all major shells on windows and linux as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. I did not know this. Thanks for explaining. Just ignore then!
Thanks all, merging! |
Closes #2818 and part of #3309
This PR adds a new
all
dependency group that contains the primary optional dependencies that we'd like most users of Altair to have installed by default.Rather than duplicate dependencies across
all
and our existingdev
group, I removed the optional runtime dependencies fromdev
and updated the development instructions to install both groups withpip install ".[all, dev]"
.I updated the documentation to recommend installing the
altair
package withpip install "altair[all]"
.