Code

feat: Adds ThemeConfig (TypedDict)#3536

Code

Merged

dangotbanned merged 165 commits intovega:mainvega/altair:mainfrom dangotbanned:config-typed-dictdangotbanned/altair:config-typed-dictCopy head branch name to clipboardSep 22, 2024

+10,121-772

Commits

Commits on Aug 12, 2024

• feat: Adds SchemaInfo.is_format

  dangotbanned

  committed
  7b324d6

• feat(typing): Annotate SchemaProperties

  dangotbanned

  committed
  0325667

• perf: Use more appropriate data structures in codegen

  Show description for 832fd72
  dangotbanned

  committed
  832fd72

• refactor: Reduce length and complexity of get_python_type_representation

  Show description for 549f42c
  dangotbanned

  committed
  549f42c

• refactor: Update codegen to use new get_python_type_representation

  dangotbanned

  committed
  1b6e008

• refactor(perf): Rewrite generate_vegalite_mark_mixin

  Show description for 148c913
  dangotbanned

  committed
  148c913

• perf: Iterate over values() when keys() are not needed

  dangotbanned

  committed
  de66450

• refactor: reorder get_python_type_representation kwargs

  dangotbanned

  committed
  8fa63de

• feat(typing): Add missing annotations

  dangotbanned

  committed
  ba08256

• refactor: Rename get_python_type_representation -> to_type_repr

  Show description for 5f35705
  dangotbanned

  committed
  5f35705

• refactor: Remove redundant is_object branch

  Show description for cb8aefc
  dangotbanned

  committed
  cb8aefc

• fix: Exclude array stub classes

  dangotbanned

  committed
  193e493

• feat(typing): Temp solution for dict in TypedDict

  Show description for b2db86c
  dangotbanned

  committed
  b2db86c

• feat(typing): Add wip ThemeConfig implementation

  dangotbanned

  committed
  566cd05

• build: run generate-schema-wrapper

  dangotbanned

  committed
  aafe73f

• Merge remote-tracking branch 'upstream/main' into config-typed-dict

  dangotbanned

  committed
  f457a92

• docs: Add doc for SchemaInfo.to_type_repr

  dangotbanned

  committed
  5d1f2a5

• fix: Use pre 3.12 fstring syntax

  dangotbanned

  committed
  40cd566

• fix: Rerun generate-schema-wrapper

  Show description for 49633be
  dangotbanned

  committed
  49633be

Commits on Aug 13, 2024

• Merge remote-tracking branch 'upstream/main' into config-typed-dict

  dangotbanned

  committed
  9c51d43

• fix(typing): Exclude core.Dict from format

  Show description for b4f7ede
  dangotbanned

  committed
  b4f7ede

• refactor: Replace is_value() case in codegen.get_args()

  Show description for a8ac7ec
  dangotbanned

  committed
  a8ac7ec

• fix(typing): Exclude RelativeBandSize from discreteBandSize

  Show description for e4f62ec
  dangotbanned

  committed
  e4f62ec

• feat(typing): Adds Value (TypedDict)

  Show description for f23880f
  dangotbanned

  committed
  f23880f

• build: run generate-schema-wrapper

  dangotbanned

  committed
  a9c8b99

• ci(ruff): Enable lint/format on notebooks

  dangotbanned

  committed
  184f2b6

• Merge remote-tracking branch 'upstream/main' into config-typed-dict

  dangotbanned

  committed
  91dacf8

Commits on Aug 14, 2024

• feat: Adds SchemaInfo.is_type_alias

  Show description for ecf7fd5
  dangotbanned

  committed
  ecf7fd5

• build: run generate-schema-wrapper

  Show description for f4cb0d4
  dangotbanned

  committed
  f4cb0d4

• refactor: Move, rename _type_checking_only_imports -> import_type_checking

  dangotbanned

  committed
  a9a738e

• feat: Adds utils.import_typing_extensions

  Show description for fcb9469
  dangotbanned

  committed
  fcb9469

• feat(typing): Adds ColorHex, is_color_hex

  Show description for 7eea237
  dangotbanned

  committed
  7eea237

• build: run generate-schema-wrapper

  dangotbanned

  committed
  3455fd7

• fix(typing): Exclude str, use ColorHex | ColorName_T

  Show description for 794e9d5
  dangotbanned

  committed
  794e9d5

• fix: Move *TODO* location

  Show description for 859e998
  dangotbanned

  committed
  859e998

• chore: Label a comment as a temp fix

  dangotbanned

  committed
  f09a14c

• feat(typing): Adds OverlayMarkDefKwds

  Show description for da516c1
  dangotbanned

  committed
  da516c1

• refactor: Rename types_from_title -> title_to_type_reprs

  dangotbanned

  committed
  fc10816

• fix: Don't escape braces, require full match for ColorHex

  dangotbanned

  committed
  ff1a3f5

• docs: Add ColorHex example with transparency

  dangotbanned

  committed
  3b32cf7

• test(typing): Adds test_is_color_hex

  dangotbanned

  committed
  7b1875d

• refactor: Promote title_to_type_reprs to a SchemaInfo method

  dangotbanned

  committed
  8ff7b00

• perf: Optimize some checks in SchemaInfo

  dangotbanned

  committed
  a59a7bd

• feat: Use a dynamic ClassVar for remapping titles

  Show description for d68fcdb
  dangotbanned

  committed
  d68fcdb

• feat(typing): Adds LinearGradientKwds, RadialGradientKwds

  Show description for e5c4b7f
  dangotbanned

  committed
  e5c4b7f

Commits on Aug 15, 2024

• fix: Include ArgInfo.required in TypedDict(s)

  Show description for 0c63dc7
  dangotbanned

  committed
  0c63dc7

• feat(typing): Adds GradientStopKwds

  dangotbanned

  committed
  46fa848

• ci: Remove old dependency m2r from mypy

  Show description for d3f2898
  dangotbanned

  committed
  d3f2898

• Merge remote-tracking branch 'upstream/main' into remove-m2r-mypy

  dangotbanned

  committed
  db0419f

• Merge branch 'main' into config-typed-dict

  dangotbanned

  committed
  da16406

• revert(ruff): Remove default ruff setting

  dangotbanned

  committed
  7d3eac9

• feat(typing): Temporarily duplicate (vega#3538)

  Show description for 4fd7628
  dangotbanned

  committed
  4fd7628

• Merge pull request #1 from vega/remove-m2r-mypy

  Show description for 5a3f9ee
  dangotbanned

  authored
  5a3f9ee

• fix: Exclude titles w/ SchemaInfo.additionalProperties

  Show description for 0ebc6bc
  dangotbanned

  committed
  0ebc6bc

• feat: Fill out MANUAL_DEFS with all remaining targets

  Show description for a5e9442
  dangotbanned

  committed
  a5e9442

• build: run generate-schema-wrapper

  dangotbanned

  committed
  9b6c4d6

• refactor: Renaming/tidying up new functions

  dangotbanned

  committed
  e2f0ed3

• refactor: Somewhat standardize imports

  dangotbanned

  committed
  f045dc6

• Merge & re-build

  dangotbanned

  committed
  d435380

• feat(typing): Finish ThemeConfig hierarchy

  Show description for bb99389
  dangotbanned

  committed
  bb99389

Commits on Aug 16, 2024

• Merge remote-tracking branch 'upstream/HEAD'

  dangotbanned

  committed
  67dc9df

• Merge remote-tracking branch 'upstream/main'

  dangotbanned

  committed
  b24dbe2

• Merge branch 'main' into config-typed-dict

  dangotbanned

  committed
  964745a

• refactor: Tidy up generate_schema_wrapper.py

  Show description for 3c9aab5
  dangotbanned

  committed
  3c9aab5

Commits on Aug 17, 2024

• perf: Reprioritise unreachable info.allOf

  Show description for 0be9f5d
  dangotbanned

  committed
  0be9f5d

• perf: Remove unused arg and compile pattern for is_valid_identifier

  dangotbanned

  committed
  882013c

• refactor(typing): Fill out some more generics

  dangotbanned

  committed
  2781969

• refactor(typing): Remove some None cases for SchemaInfo

  Show description for 9e1c8c4
  dangotbanned

  committed
  9e1c8c4

Commits on Aug 27, 2024

• Merge branch 'main' into config-typed-dict

  dangotbanned

  authored
  b6fff04

Commits on Sep 1, 2024

• Merge branch 'main' into config-typed-dict

  dangotbanned

  authored
  cc6e9bd

Commits on Sep 3, 2024

• Merge remote-tracking branch 'upstream/main' into config-typed-dict

  dangotbanned

  committed
  9c94918

• Merge branch 'config-typed-dict' of https://github.com/dangotbanned/altair into config-typed-dict

  dangotbanned

  committed
  1b3202b

• chore: Remove outdated TODO

  dangotbanned

  committed
  11280df

• fix(typing): Resolve/ignore typing in tools/

  dangotbanned

  committed
  f6b4923

Commits on Sep 5, 2024

• Merge branch 'main' into config-typed-dict

  dangotbanned

  committed
  a5bdd47

Commits on Sep 6, 2024

• Merge remote-tracking branch 'upstream/main' into config-typed-dict

  dangotbanned

  committed
  068c484

Commits on Sep 7, 2024

• docs: Add note on RelativeBandSize exclusion

  dangotbanned

  committed
  9e35e30

• feat: Adds SchemaProperties.__len__

  dangotbanned

  committed
  2efe2ea

• feat(typing): Enable type checking on tools/

  Show description for d922e4b
  dangotbanned

  committed
  d922e4b

• refactor(typing): Fake immutability in SchemaInfo

  dangotbanned

  committed
  1330708

• refactor: Make SchemaInfo effectively immutable

  Show description for 230d625
  dangotbanned

  committed
  230d625

• feat: Make SchemaInfo hashable

  dangotbanned

  committed
  a67755e

• feat(DRAFT): Add WIP config schema sourcing

  Show description for ae23b23
  dangotbanned

  committed
  ae23b23

• ci: Add patterns for pyright

  Show description for f62c82a
  dangotbanned

  committed
  f62c82a

Commits on Sep 8, 2024

• perf: Use cheaper comparison for SchemaInfo.__eq__

  Show description for a70f259
  dangotbanned

  committed
  a70f259

• refactor: iter_children -> SchemaInfo.iter_descendants

  Show description for e40768e
  dangotbanned

  committed
  e40768e

• feat: Avoid manual defs

  Show description for 6334db0
  dangotbanned

  committed
  6334db0

• build: run generate-schema-wrapper

  Show description for 2d89ad7
  dangotbanned

  committed
  2d89ad7

• feat: Adds _config.__all__

  dangotbanned

  committed
  0af1cd1

Commits on Sep 9, 2024

• refactor: Un-special-case Dict, include in SchemaInfo.is_type_alias

  Show description for 2670e3b
  dangotbanned

  committed
  2670e3b

• Merge branch 'main' into config-typed-dict

  dangotbanned

  authored
  6926973

• Merge remote-tracking branch 'upstream/main' into config-typed-dict

  dangotbanned

  committed
  836fc00

• Merge branch 'config-typed-dict' of https://github.com/dangotbanned/altair into config-typed-dict

  dangotbanned

  committed
  ba70325

• docs: Update comments in SchemaInfo.title_to_type_reprs

  dangotbanned

  committed
  d63b8a6

• refactor: is_relevant_schema -> SchemaInfo.is_theme_config_target

  Show description for ebfdbd4
  dangotbanned

  committed
  ebfdbd4

• refactor: Simplify generate_config_typed_dicts

  Show description for 96a7460
  dangotbanned

  committed
  96a7460

• docs: Link to discussion for unresolvable issue

  Show description for b3a7fb3
  dangotbanned

  committed
  b3a7fb3

• style: Use constant convention FOR_TYPE_HINTS

  dangotbanned

  committed
  aae8e6e

• feat(typing): Accept an Iterator in indent_docstring

  Show description for 732b31d
  dangotbanned

  committed
  732b31d

• feat: Adds initial docs for _config.py

  dangotbanned

  committed
  5c33b2c

• build: run generate-schema-wrapper

  dangotbanned

  committed
  0a04d4d

• Merge branch 'main' into config-typed-dict

  dangotbanned

  authored
  7bb0b8e

• docs: Add summary for ThemeConfig

  Show description for b486f10
  dangotbanned

  committed
  b486f10

• test(typing): Adds test_theme_config_typing

  Show description for 81349ea
  dangotbanned

  committed
  81349ea

Commits on Sep 10, 2024

• Merge remote-tracking branch 'upstream/main' into config-typed-dict

  dangotbanned

  committed
  b43deb5

• test: Remove Vega-only properties from theme tests

  Show description for ff364a1
  dangotbanned

  committed
  ff364a1

• fix(typing): Misc typing fixes

  dangotbanned

  committed
  bf36b69

• fix: Remove Vega-only properties from vendored vega-themes.json

  Show description for 79804ec
  dangotbanned

  committed
  79804ec

• fix: Support hyphenated keys in TypedDict(s)

  Show description for 0bdfa72
  dangotbanned

  committed
  0bdfa72

• chore: Add note on remaining issue

  dangotbanned

  committed
  427a0dd

• Merge remote-tracking branch 'upstream/main' into config-typed-dict

  dangotbanned

  committed
  6f13b0b

• fix(DRAFT): Hack workaround for Padding

  Show description for e564ca5
  dangotbanned

  committed
  e564ca5

Commits on Sep 11, 2024

• test: Adds binste_altair_theme

  Show description for 73f6b25
  dangotbanned

  committed
  73f6b25

• test: Adds husky_theme

  Show description for ab41cb7
  dangotbanned

  committed
  ab41cb7

• test: Refactor, add runtime testing of ThemeConfig

  dangotbanned

  committed
  1dc4c05

• refactor: Reuse finalize_type_reprs

  Show description for 5315a3d
  dangotbanned

  committed
  5315a3d

• chore: Rename init_subclass_args -> metaclass_kwds

  Show description for c816ca3
  dangotbanned

  committed
  c816ca3

• refactor: Use only generate_typed_dict for TypedDict(s)

  dangotbanned

  committed
  7c55a35

• refactor: Move process_description to tools.schemapi.utils

  Show description for 44624ef
  dangotbanned

  committed
  44624ef

• docs: Add note to SchemaGenerator.subclasses

  dangotbanned

  committed
  b5e54d8

• refactor: Include process_description in deep_description

  Show description for 6d744f8
  dangotbanned

  committed
  6d744f8

• perf: Replace relative links on entire description

  Show description for dd05abd
  dangotbanned

  committed
  dd05abd

• refactor(perf): Compile patterns and tidy up fix_docstring_issues

  Show description for bed1285
  dangotbanned

  committed
  bed1285

• chore: Remove unused code

  dangotbanned

  committed
  025aae5

• refactor: Factor out _doc_args, add iter_args

  dangotbanned

  committed
  9bc28d4

• refactor: Remove unused ruff_format_str

  Show description for 626401e
  dangotbanned

  committed
  626401e

Commits on Sep 12, 2024

• refactor: Factor out _signature_args, enhance ArgInfo.iter_args

  Show description for a5c0567
  dangotbanned

  committed
  a5c0567

• refactor: Add SchemaInfo.from_refname constructor

  Show description for 36fdaa6
  dangotbanned

  committed
  36fdaa6

• docs: Add some missing docs

  dangotbanned

  committed
  1b236f9

• refactor: Reorganize .rst utils to be together

  dangotbanned

  committed
  160ee63

• refactor: Remove unused parameters

  dangotbanned

  committed
  7e85b36

• refactor: Move more constants into templates

  dangotbanned

  committed
  36ebca6

• refactor: Accept multiple remap titles

  Show description for 7b7390a
  dangotbanned

  committed
  7b7390a

• docs: Finish generate_typed_dict

  dangotbanned

  committed
  af7c17c

• feat(typing): Adds RowCol generic

  Show description for 072f512
  dangotbanned

  committed
  072f512

Commits on Sep 13, 2024

• feat(typing): Adds missing types for TopLevelUnitSpec

  Show description for 007f373
  dangotbanned

  committed
  007f373

• fix: Add RowCol to _typing.__all__

  dangotbanned

  committed
  2afdc19

• fix: Version-gate typing_extensions in utils

  dangotbanned

  committed
  2c70eb6

• feat: Support callables in ArgInfo.iter_args

  dangotbanned

  committed
  ef3df18

• feat: Define ThemeConfig as subset of TopLevelUnitSpec

  Show description for 4f3c0e7
  dangotbanned

  committed
  4f3c0e7

• build: run generate-schema-wrapper

  dangotbanned

  committed
  ff01520

• test: Update test_theme to account for level correction

  Show description for 0b8eda8
  dangotbanned

  committed
  0b8eda8

• fix(typing): Use a single TypeVar for RowCol

  Show description for 80b21d5
  dangotbanned

  committed
  80b21d5

• feat(typing): Add ThemeConfig to alt.typing

  dangotbanned

  committed
  810921c

• feat(typing): Update all ThemeRegistry annotations

  dangotbanned

  committed
  79fb2fb

• fix(typing): Satisfy mypy on utils.core.update_nested

  Show description for c8ccb05
  dangotbanned

  committed
  c8ccb05

• fix: run generate-schema-wrapper

  Show description for 26c6ede
  dangotbanned

  committed
  26c6ede

• feat(typing): Adds PaddingKwds

  Show description for 4933e54
  dangotbanned

  committed
  4933e54

• refactor: Factor out _typed_dict_doc

  dangotbanned

  committed
  2847293

• refactor: Factor out _typed_dict_args

  dangotbanned

  committed
  f386052

• docs: Update generate_typed_dict

  dangotbanned

  committed
  ed24ada

• refactor: Reuse ArgInfo.iter_args in SchemaGenerator

  dangotbanned

  committed
  ddf4636

• chore: Removed outdated comment

  dangotbanned

  authored
  0c8f9e2

Commits on Sep 16, 2024

• Merge branch 'main' into config-typed-dict

  dangotbanned

  authored
  bf29786

• Update altair/vegalite/v5/schema/_typing.py

  Show description for cafd696
  

  dangotbanned

  and

  binste

  authored
  cafd696

• fix: Apply suggested fix at source

  Show description for 0bb7a86
  dangotbanned

  committed
  0bb7a86

• style: Remove extra whitespace from docs

  dangotbanned

  committed
  ffb3214

• refactor: Reuse literals, add _typing dicts to _config.__all__

  Show description for aaffebd
  dangotbanned

  committed
  aaffebd

• feat: Export _config.py as altair.typing.theme

  Show description for 12b6410
  dangotbanned

  committed
  12b6410

• docs: Use :class: directive on TypedDict(s)

  Show description for 6e4af95
  dangotbanned

  committed
  6e4af95

• fix: Define typing as a package to support submodules

  Show description for d4bd6db
  dangotbanned

  committed
  d4bd6db

Commits on Sep 17, 2024

• fix: Update TypedDict import in _typing.py

  Show description for 8db4469
  dangotbanned

  committed
  8db4469

• Merge branch 'main' into config-typed-dict

  dangotbanned

  authored
  93334b7

Commits on Sep 21, 2024

• Merge branch 'main' into config-typed-dict

  dangotbanned

  authored
  8519444

Commits on Sep 22, 2024

• Merge remote-tracking branch 'upstream/main' into config-typed-dict

  dangotbanned

  committed
  b36519f