-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typing): Improve Then
annotations, autocompletion, docs
#3567
Commits on Sep 4, 2024
-
fix(DRAFT): Add examples for
SchemaLike
Purely demonstrating type checking behaviour for vega#3552 (comment)
Configuration menu - View commit details
-
Copy full SHA for 331a52e - Browse repository at this point
Copy the full SHA 331a52eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 633c0c2 - Browse repository at this point
Copy the full SHA 633c0c2View commit details
Commits on Sep 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f59a290 - Browse repository at this point
Copy the full SHA f59a290View commit details -
style: Reorder
_Condition...
definitionsRevisting these I found it confusing that they were defined like (A, B, B, A). They are now (A, A, B, B) so it is clearer how they are linked
Configuration menu - View commit details
-
Copy full SHA for f34abe9 - Browse repository at this point
Copy the full SHA f34abe9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2dc1f21 - Browse repository at this point
Copy the full SHA 2dc1f21View commit details -
Aiming to get all of these to pass, without breaking anything else. **CI fail expected**
Configuration menu - View commit details
-
Copy full SHA for c86a107 - Browse repository at this point
Copy the full SHA c86a107View commit details
Commits on Sep 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5ab0616 - Browse repository at this point
Copy the full SHA 5ab0616View commit details -
Configuration menu - View commit details
-
Copy full SHA for adf3e56 - Browse repository at this point
Copy the full SHA adf3e56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7315582 - Browse repository at this point
Copy the full SHA 7315582View commit details -
Configuration menu - View commit details
-
Copy full SHA for d169a1b - Browse repository at this point
Copy the full SHA d169a1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c5632f4 - Browse repository at this point
Copy the full SHA c5632f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f74e8e - Browse repository at this point
Copy the full SHA 2f74e8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 160b16c - Browse repository at this point
Copy the full SHA 160b16cView commit details -
fix: Make
Parameter
,(Parameter|Selection)Expression
SchemaLike
……-compliant Can't define this in `OperatorMixin`, as `Expression` uses `{"type": "string"}`
Configuration menu - View commit details
-
Copy full SHA for e470a98 - Browse repository at this point
Copy the full SHA e470a98View commit details -
Added a lot of notes here, since I was surpised `Then` would not be allowed in the cases I had planned originally
Configuration menu - View commit details
-
Copy full SHA for f49c9f5 - Browse repository at this point
Copy the full SHA f49c9f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a773c97 - Browse repository at this point
Copy the full SHA a773c97View commit details -
fix: Update
TypedDict
version boundWe're using a feature that didn't make it into `3.13` yet https://peps.python.org/pep-0728/
Configuration menu - View commit details
-
Copy full SHA for 9f49ef6 - Browse repository at this point
Copy the full SHA 9f49ef6View commit details -
Configuration menu - View commit details
-
Copy full SHA for c420a1c - Browse repository at this point
Copy the full SHA c420a1cView commit details -
fix: Confirm
ChainedWhen.then
structural soundnessThe warning raised by `pyright` here was actually quite helpful. Essentially, a shorthand string is never allowed here vega#3552 (comment)
Configuration menu - View commit details
-
Copy full SHA for 7925d90 - Browse repository at this point
Copy the full SHA 7925d90View commit details -
test: Update
test_when_multiple_fields
We now provide more precise errors identifying exactly which call produced the issue. Previously, the `.then("min(foo):Q")` was silently allowed - but later rejected in `.otherwise()`.
Configuration menu - View commit details
-
Copy full SHA for 960e134 - Browse repository at this point
Copy the full SHA 960e134View commit details -
chore(typing): Add a temporary ignore
I'm fairly sure this is fixed in another branch, so leaving this here for less of a conflict https://github.com/vega/altair/pull/3547/files#diff-bbe4e187b18d242a366c820d023afd89041759cb96e4ec66c3f34559a72c2f9d
Configuration menu - View commit details
-
Copy full SHA for 5ee39c2 - Browse repository at this point
Copy the full SHA 5ee39c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 969e0e3 - Browse repository at this point
Copy the full SHA 969e0e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cad6af - Browse repository at this point
Copy the full SHA 8cad6afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d9f248 - Browse repository at this point
Copy the full SHA 2d9f248View commit details -
Configuration menu - View commit details
-
Copy full SHA for da9784e - Browse repository at this point
Copy the full SHA da9784eView commit details -
feat: Use
module.__all__
to simplifygenerate_api_docs
Removes the need for hardcoding restrictions in multiple places
Configuration menu - View commit details
-
Copy full SHA for 1971daa - Browse repository at this point
Copy the full SHA 1971daaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e51d1e - Browse repository at this point
Copy the full SHA 3e51d1eView commit details
Commits on Sep 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d20109e - Browse repository at this point
Copy the full SHA d20109eView commit details -
refactor(typing): Factor out
_ConditionType
, use_Condition
(`Typ……edDict`) - Adds some more consistency between `condition` and `when-then-otherwise` - 1 less thing to think about
Configuration menu - View commit details
-
Copy full SHA for 0a6d599 - Browse repository at this point
Copy the full SHA 0a6d599View commit details -
test(typing): Wrap returned "immutable"
TypedDict
before modifyingThis isn't a runtime concern, just to satisfy typing
Configuration menu - View commit details
-
Copy full SHA for 7865c91 - Browse repository at this point
Copy the full SHA 7865c91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a93309 - Browse repository at this point
Copy the full SHA 0a93309View commit details -
feat(typing): Adds
Any...
aliases inchannels.py
Mostly pushing this as an experiment. Shortens signatures, but there is a cost to the indirection vega#3567 (comment)
Configuration menu - View commit details
-
Copy full SHA for 08bf16e - Browse repository at this point
Copy the full SHA 08bf16eView commit details
Commits on Sep 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 19966c1 - Browse repository at this point
Copy the full SHA 19966c1View commit details
Commits on Sep 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7351395 - Browse repository at this point
Copy the full SHA 7351395View commit details
Commits on Sep 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ec5e415 - Browse repository at this point
Copy the full SHA ec5e415View commit details