Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct y axis title in boxplot when mark.extent isnt set #9483

Merged
merged 5 commits into from
Feb 14, 2025

Conversation

MarcBaeuerle
Copy link
Contributor

@MarcBaeuerle MarcBaeuerle commented Nov 30, 2024

closes #9223

The issue rose when mark.extent was not explicitly set, causing the tukey box layer encoding to have a missing axis object. The original implementation removes the axis.title despite it being different from the title when explicitly setting the axis.title. In the issue, the title itself was 'shannon' while the axis.title was 'new title'.

Checklist

  • This PR is atomic (i.e., it fixes one issue at a time).
  • The title is a concise semantic commit message (e.g. "fix: correctly handle undefined properties").
  • yarn test runs successfully

Sorry, something went wrong.

@MarcBaeuerle MarcBaeuerle requested a review from a team as a code owner November 30, 2024 09:16
@MarcBaeuerle MarcBaeuerle changed the title fix: correct y axis title in boxplot when mark.extent isnt set ##9223 fix: correct y axis title in boxplot when mark.extent isnt set Nov 30, 2024
@MarcBaeuerle
Copy link
Contributor Author

Hi @domoritz, I don't mean to be rude by pinging you, but I just included a pr description to give some context into the changes I made. Let me know if there is anything else missing since I'm new to this. Thank you!

@domoritz
Copy link
Member

domoritz commented Dec 3, 2024

Thanks for the pull request. I'm super overloaded with end of semester things right now. Hopefully someone else can look at this or I will over the winter break.

Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good. Can you please add a test so that we can merge this?

@domoritz domoritz merged commit f3dc811 into vega:main Feb 14, 2025
8 checks passed
@domoritz
Copy link
Member

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting y-axis title in boxplot doesn't work as expected
2 participants