Revamp grpc support #522
Merged
Revamp grpc support #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmmease
added a commit
that referenced
this pull request
Nov 16, 2024
* Add grpc VegaFusionRuntimeTraim implementation, use from Python * include inline datasets in query_request * fix tests * fix tests * Add unimplemented stubs in wasm implementation * fmt * Move methods up to VegaFusionRuntimeTrait * fmt/fix * handle inline datasets in vegafusion-wasm * warning / format * fix requested indices * fix python lint * fix expected error message * relock, mypy fixes * bring back ignores for CI?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for connecting to VegaFusionServer over grpc to the Python library. This is done using the tonic Rust library, so it does not introduce a dependency on the python grpcio package.