Hull, armor and shield components

[royfalk]

• modify ship_view/upgrade_view to support 4 facet armor and new shield keys
• Fix bug in ship_view where ypr is 0.
• Modify minimize_parts script to create new ships.json and units.json
• Create new ships.json and units.json
• Fix some stuff in units_old.json

Complements vegastrike/Vega-Strike-Engine-Source#1016

Code Changes:

• Have the PR Validation Tests been run? See https://github.com/vegastrike/Vega-Strike-Engine-Source/wiki/Pull-Request-Validation

Issues:

• *.blank ships have 0 facets and likely can't upgrade shields.
• Upgrades, such as armor have shield_facets:0

[stephengtuggy]

Looks good for the most part. Let's see if we can fix the zero-facet issues before merging this.

Zero-facet issues apparently fixed

[stephengtuggy]

That’s looking quite a bit better. I think I’d like to see these changes get play-tested before we merge them, but I think there’s a good chance that they will pass muster.

I will see if I can play-test this PR myself, once I’m back to a computer.

[kheckwrecker]

When running Vegastrike in a debugger, I'm seeing a lot of these error messages:

Unit::LoadRow: invalid stof argument trying to parse shield facets
Exception thrown at 0x00007FF84533B699 in vegastrike-engine.exe: Microsoft C++ exception: std::invalid_argument at memory location 0x000000E4210FC360.
Exception thrown at 0x00007FF84533B699 in vegastrike-engine.exe: Microsoft C++ exception: std::invalid_argument at memory location 0x000000E4210F9F90.
Unit::LoadRow: invalid stof argument trying to parse shield facets
Exception thrown at 0x00007FF84533B699 in vegastrike-engine.exe: Microsoft C++ exception: std::invalid_argument at memory location 0x000000E4210FC360.
Exception thrown at 0x00007FF84533B699 in vegastrike-engine.exe: Microsoft C++ exception: std::invalid_argument at memory location 0x000000E4210F9F90.
Unit::LoadRow: invalid stof argument trying to parse shield facets
Exception thrown at 0x00007FF84533B699 in vegastrike-engine.exe: Microsoft C++ exception: std::invalid_argument at memory location 0x000000E4210FC360.
Exception thrown at 0x00007FF84533B699 in vegastrike-engine.exe: Microsoft C++ exception: std::invalid_argument at memory location 0x000000E4210F9F90.
Exception thrown at 0x00007FF84533B699 in vegastrike-engine.exe: Microsoft C++ exception: std::invalid_argument at memory location 0x000000E4210FC360.
Exception thrown at 0x00007FF84533B699 in vegastrike-engine.exe: Microsoft C++ exception: std::invalid_argument at memory location 0x000000E4210F9F90.
Exception thrown at 0x00007FF84533B699 in vegastrike-engine.exe: Microsoft C++ exception: std::invalid_argument at memory location 0x000000E4210FC360.
Exception thrown at 0x00007FF84533B699 in vegastrike-engine.exe: Microsoft C++ exception: std::invalid_argument at memory location 0x000000E4210F9F90.
Unit::LoadRow: invalid stof argument trying to parse shield facets

Will this PR solve these errors? If it might, I can apply this PR and play test it.

[royfalk]

Does your game crash afterward?
I don't think it fixes this. I'm seeing something similar on Linux.

[kheckwrecker]

Does your game crash afterward? I don't think it fixes this. I'm seeing something similar on Linux.

No, it doesn't crash due to these errors.

[evertvorster]

Indeed, the change to Oswald's shield generator did the trick.

[stephengtuggy]

LGTM

[evertvorster]

This one is good to be merged in my opinion.