Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timeout handling and stopped individual property errors being fatal #870

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

MatthewDaggitt
Copy link
Collaborator

Fixes #869 for @tflinkow. Errors are no longer fatal and adds some timeout detection. Can't actually test the timeout detection as I can't get Marabou to actually timeout (see comment in issue), but the worst that will happen is that Vehicle will treat it as an error which isn't disastrous.

@MatthewDaggitt MatthewDaggitt added bug Something isn't working backend:verifiers labels Dec 12, 2024
@MatthewDaggitt MatthewDaggitt added this to the v0.16 milestone Dec 12, 2024
@MatthewDaggitt MatthewDaggitt added this pull request to the merge queue Dec 13, 2024
@MatthewDaggitt MatthewDaggitt removed this pull request from the merge queue due to a manual request Dec 13, 2024
@MatthewDaggitt
Copy link
Collaborator Author

Also added printing of verification stats as per request.

@MatthewDaggitt MatthewDaggitt added this pull request to the merge queue Dec 13, 2024
Merged via the queue into dev with commit be98e43 Dec 13, 2024
20 checks passed
@MatthewDaggitt MatthewDaggitt deleted the timeouts branch December 13, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:verifiers bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for timeout
1 participant