Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty build tags adding a tags parameter #874

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

RangelReale
Copy link
Contributor

@RangelReale RangelReale commented Dec 30, 2024

Description

strings.Split always returns at least 1 item in the result array, even for the empty string. This makes the packages.Load call to always have an empty -tags parameter.

  • Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Go used when building/testing:

  • 1.22
  • 1.23

How Has This Been Tested?

The debug log output showed the empty -tags parameter.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@LandonTClipp
Copy link
Collaborator

Good catch, thanks 👍🏻

@LandonTClipp LandonTClipp merged commit 6a54b28 into vektra:master Dec 30, 2024
4 checks passed
@RangelReale RangelReale deleted the fix-empty-buildtags branch December 30, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants