Skip to content

Commit

Permalink
v2.3.2 logs
Browse files Browse the repository at this point in the history
  • Loading branch information
michaelavoyan committed Feb 29, 2024
1 parent 36dcc8d commit a700819
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 5 deletions.
4 changes: 2 additions & 2 deletions VCL/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ android {
defaultConfig {
minSdk 24
targetSdk 33
versionName "2.3.1"
versionCode 131
versionName "2.3.2"
versionCode 132
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
consumerProguardFiles "consumer-rules.pro"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,12 @@ internal class CredentialIssuerVerifierImpl(
// https://velocitycareerlabs.atlassian.net/browse/VL-6178?focusedCommentId=46933
// https://velocitycareerlabs.atlassian.net/browse/VL-6988
// if (jwtCredential.iss == did)
if (Utils.getCredentialIssuerId(jwtCredential) == did) {
val credentialIssuerId = Utils.getCredentialIssuerId(jwtCredential)
VCLLog.d(
TAG,
"Comparing credentialIssuerId: ${credentialIssuerId ?: ""} with did: $did"
)
if (credentialIssuerId == did) {
isCredentialVerified = true
} else {
globalError =
Expand All @@ -263,11 +268,21 @@ internal class CredentialIssuerVerifierImpl(
} ?: run {
globalError =
VCLError(errorCode = VCLErrorCode.IssuerRequiresNotaryPermission.value)

VCLLog.e(
TAG,
"DID NOT FOUND for K = $K and credentialSubject = $credentialSubject"
)
}
} ?: run {
// When K is null, the credential will pass these checks:
// https://velocitycareerlabs.atlassian.net/browse/VL-6181?focusedCommentId=44343
isCredentialVerified = true

VCLLog.d(
TAG,
"Key for primary organization NOT FOUND for active context:\n$activeContext"
)
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ import org.junit.Before
import org.junit.Test

internal class CredentialIssuerVerifierTest {
val TAG = CredentialIssuerVerifierTest::class.simpleName

private lateinit var subject1: CredentialIssuerVerifier
private lateinit var subject2: CredentialIssuerVerifier
private lateinit var subject3: CredentialIssuerVerifier
Expand Down

0 comments on commit a700819

Please sign in to comment.